RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1722875 - Duplicate address detection code prints confusing message
Summary: Duplicate address detection code prints confusing message
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: dracut
Version: 8.0
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: 8.0
Assignee: Lukáš Nykrýn
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-21 14:38 UTC by Renaud Métrich
Modified: 2021-02-01 07:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-01 07:41:41 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Renaud Métrich 2019-06-21 14:38:05 UTC
This bug was initially created as a copy of Bug #1722873

I am copying this bug because issue exists in RHEL8 for 35network-legacy module:

35network-legacy/ifup.sh:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
            if command -v arping2 >/dev/null; then
                if arping2 -q -C 1 -c 2 -I $netif -0 $ip ; then
                    warn "Duplicate address detected for $ip for interface $netif."
                    return 1
                fi
            else
                if ! arping -f -q -D -c 2 -I $netif $ip ; then
                    warn "Duplicate address detected for $ip for interface $netif."
                    return 1
                fi
            fi
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------


Description of problem:

In dracut's 40network module, arping is used to detect Duplicate addresses :

40network/ifup.sh:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
            if ! arping -f -q -D -c 2 -I $netif $ip; then
                warn "Duplicate address detected for $ip for interface $netif."
                return 1
            fi
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

40network/dhclient-script.sh code:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
            if ! arping -f -q -D -c 2 -I $netif $new_ip_address ; then
                warn "Duplicate address detected for $new_ip_address while doing dhcp. retrying"
                exit 1
            fi
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

For some reason, if the network interface is not available, in particular in the "ifup.sh" case (because for dhclient, it's retried), arping will print "Device XXX not available" but then dracut will abort and print "Duplicate address detected" which is not the real error.


Version-Release number of selected component (if applicable):

All dracut version, including RHEL8's one


How reproducible:

Don't know how to reproduce arping's "Device XXX not available" error


Additional info:

arping returns exit(2) upon device error and other errors (mostly getopt errors), whereas exit(1) is returned when a duplicate address is found:

exit(2):
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
int
main(int argc, char **argv)
{
[...]
                        fprintf(stderr, "arping: Device %s not available.\n", device.name);
                        exit(2);
[...]
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

exit(1) (Duplicate address detection, dad == 1):
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
void finish(void)
{
        if (!quiet) {
                printf("Sent %d probes (%d broadcast(s))\n", sent, brd_sent);
                printf("Received %d response(s)", received);
[...]
        if (dad)
                exit(!!received);
[...]
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

Dracut code should distinguish between rc == 2 and rc == 1 instead of using "! arping" test condition.

Comment 4 RHEL Program Management 2021-02-01 07:41:41 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.


Note You need to log in before you can comment on or make changes to this bug.