Created attachment 1592584 [details] production.log Description of problem: When trying to register 5.11 to REd Hat Updates, I am getting an error in the production log (Maybe because there are no attachments or repos yet?): [----] F, [2019-07-22T08:25:44.164305 #7974:2aca7db34d78] FATAL -- : Error caught: [NoMethodError] undefined method `length' for nil:NilClass /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-c5ad825c8837/app/controllers/ops_controller/settings/rhn.rb:221:in `rhn_allow_save?' Version-Release number of selected component (if applicable): cfme-5.11.0.15-1.el8cf.x86_64 How reproducible: 1/1 Steps to Reproduce: 1. Get CFME 2. try attaching to RHN 3. Actual results: 1) The info in Red Hat Updates dialog doesn't get saved probably due to this error that displays only in logs. 2) No indication of error in the WebUI 3) The system doesn't subscribe. Expected results: Error indication in the WebUI in case system cannot be subscribed. System subscribed fine. Additional info:
Created attachment 1594600 [details] rhn.png
https://github.com/ManageIQ/manageiq-ui-classic/pull/5908
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/c86c93649ebbda226789ab8b1dc203c299f34281 commit c86c93649ebbda226789ab8b1dc203c299f34281 Author: Dávid Halász <dhalasz> AuthorDate: Tue Jul 30 10:57:41 2019 -0400 Commit: Dávid Halász <dhalasz> CommitDate: Tue Jul 30 10:57:41 2019 -0400 Make the check against Satellite organization safe to fix RHSM issues Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1731962 app/controllers/ops_controller/settings/rhn.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/f404f1e00dc96c89cecb1f77957e2ecdd0699888 commit f404f1e00dc96c89cecb1f77957e2ecdd0699888 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Jul 30 11:58:36 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 30 11:58:36 2019 -0400 Merge pull request #5908 from skateman/rhn-organization-try Make the check against Satellite organization safe to fix RHSM issues (cherry picked from commit d1822704512634446b858017adf999e560d7c850) https://bugzilla.redhat.com/show_bug.cgi?id=1731962 app/controllers/ops_controller/settings/rhn.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fist of all, I cannot test whether the update actually updates, as there is not any newer version than I am veryfying. This bug doesn't seem to be completely fixed although I think we did move towards the good end. When the credentials typed-in are valid, they are saved and I see a notification about that, but when I *change* the password afterwards, I am allowed to save without verifying. This results in green notification with info that creds were saved, but then in the logs I see: :guid: fe9f25af-d5fe-4c7a-a611-81fcb0eae88a [----] I, [2019-08-12T08:31:07.634353 #7870:2ad4d3d005c0] INFO -- : MIQ(MiqEventHandler::Runner#message_sync_config) MIQ(MiqEventHandler::Runner) Synchronizing configuration complete... [----] E, [2019-08-12T08:31:08.064750 #7905:2ad4d3d005c0] ERROR -- : MIQ(MiqQueue#deliver) Message id: [200], Error: [username and password are required] [----] E, [2019-08-12T08:31:08.065311 #7905:2ad4d3d005c0] ERROR -- : [ArgumentError]: username and password are required Method:[block (2 levels) in <class:LogProxy>] [----] E, [2019-08-12T08:31:08.065807 #7905:2ad4d3d005c0] ERROR -- : /opt/rh/cfme-gemset/gems/linux_admin-1.2.4/lib/linux_admin/registration_system/subscription_manager.rb:29:in `organizations' /opt/rh/cfme-gemset/gems/linux_admin-1.2.4/lib/linux_admin/registration_system/subscription_manager.rb:15:in `validate_credentials' /opt/rh/cfme-gemset/gems/linux_admin-1.2.4/lib/linux_admin/registration_system.rb:14:in `method_missing' /var/www/miq/vmdb/app/models/registration_system.rb:76:in `verify_credentials' /var/www/miq/vmdb/app/models/miq_queue.rb:460:in `block in dispatch_method' /usr/share/ruby/timeout.rb:93:in `block in timeout' /usr/share/ruby/timeout.rb:33:in `block in catch' /usr/share/ruby/timeout.rb:33:in `catch' /usr/share/ruby/timeout.rb:33:in `catch' /usr/share/ruby/timeout.rb:108:in `timeout' /var/www/miq/vmdb/app/models/miq_queue.rb:458:in `dispatch_method' /var/www/miq/vmdb/app/models/miq_queue.rb:435:in `block in deliver' /var/www/miq/vmdb/app/models/user.rb:290:in `with_user_group' /var/www/miq/vmdb/app/models/miq_queue.rb:435:in `deliver' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:104:in `deliver_queue_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:137:in `deliver_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:155:in `block in do_work' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:149:in `loop' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:149:in `do_work' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:329:in `block in do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:326:in `loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:326:in `do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:153:in `run' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:127:in `start' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:22:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:398:in `block in start_runner_via_fork' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork' /var/www/miq/vmdb/app/models/miq_worker.rb:396:in `start_runner_via_fork' /var/www/miq/vmdb/app/models/miq_worker.rb:386:in `start_runner' /var/www/miq/vmdb/app/models/miq_worker.rb:437:in `start' /var/www/miq/vmdb/app/models/miq_worker.rb:269:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:147:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_worker.rb:147:in `times' /var/www/miq/vmdb/app/models/miq_worker.rb:147:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:54:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `each' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server.rb:154:in `start' /var/www/miq/vmdb/app/models/miq_server.rb:245:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:27:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:48:in `start' /var/www/miq/vmdb/lib/workers/bin/evm_server.rb:4:in `<main>' [----] I, [2019-08-12T08:31:08.066101 #7905:2ad4d3d005c0] INFO -- : MIQ(MiqQueue#delivered) Message id: [200], State: [error], Delivered in [0.652010474] seconds [----] I, [2019-08-12T08:31:08.068745 #7905:2ad4d3d005c0] INFO -- : MIQ(MiqQueue#m_callback) Message id: I am not sure what is the expected behaviour, but I don't think exception in the log is right in this case. I think user should not be allowed to save without verification.
I think that's a separate bug, the form is allowed to be submitted without validation. Can you please create a separate issue for that? Thanks
I found I already reported the issue from comment 9: BZ#1732067