Bug 1732735 - Review Request: perl-Module-Build-Using-PkgConfig - Extend Module::Build to easily use platform libraries provided by pkg-config
Summary: Review Request: perl-Module-Build-Using-PkgConfig - Extend Module::Build to e...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-24 08:56 UTC by Jitka Plesnikova
Modified: 2019-07-24 14:40 UTC (History)
2 users (show)

Fixed In Version: perl-Module-Build-Using-PkgConfig-0.03-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-24 14:40:58 UTC
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2019-07-24 08:56:14 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Module-Build-Using-PkgConfig/perl-Module-Build-Using-PkgConfig.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Module-Build-Using-PkgConfig/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.src.rpm

Description:
This subclass of Module::Build provides some handy methods to assist the
Build.PL script of XS-based module distributions that make use of platform
libraries managed by pkg-config.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2019-07-24 11:29:18 UTC
Url and Source0 addresses are Ok.
Source0 archive (SHA-256: 11774a6914bcfa0915f9f01c3041b16878d52ad86d83ecedbe62e68d4f41ecc1) is original. Ok.
Summary is Ok.
Description verified from lib/Module/Build/Using/PkgConfig.pm. Ok.
License verified from lib/Module/Build/Using/PkgConfig.pm, LICENSE, and Build.PL. Ok.
No XS code, noarch BuildArch is Ok.
Buildrequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Module-Build-Using-PkgConfig.spec ../SRPMS/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.src.rpm ../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul 24 13:24 /usr/share/doc/perl-Module-Build-Using-PkgConfig
-rw-r--r--    1 root     root                      498 Apr 11 14:06 /usr/share/doc/perl-Module-Build-Using-PkgConfig/Changes
-rw-r--r--    1 root     root                     5704 Apr 11 14:06 /usr/share/doc/perl-Module-Build-Using-PkgConfig/README
drwxr-xr-x    2 root     root                        0 Jul 24 13:24 /usr/share/licenses/perl-Module-Build-Using-PkgConfig
-rw-r--r--    1 root     root                    18418 Apr 11 14:06 /usr/share/licenses/perl-Module-Build-Using-PkgConfig/LICENSE
-rw-r--r--    1 root     root                     3996 Jul 24 13:24 /usr/share/man/man3/Module::Build::Using::PkgConfig.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul 24 13:24 /usr/share/perl5/vendor_perl/Module
drwxr-xr-x    2 root     root                        0 Jul 24 13:24 /usr/share/perl5/vendor_perl/Module/Build
drwxr-xr-x    2 root     root                        0 Jul 24 13:24 /usr/share/perl5/vendor_perl/Module/Build/Using
-rw-r--r--    1 root     root                    12808 Jul 24 13:24 /usr/share/perl5/vendor_perl/Module/Build/Using/PkgConfig.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(base)
      1 perl(ExtUtils::PkgConfig)
      1 perl(Module::Build)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(Module::Build::Using::PkgConfig) = 0.03
      1 perl-Module-Build-Using-PkgConfig = 0.03-1.fc31
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36458530). Ok.

This package is in line with Fedora and Perl packaging guide lines.

Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2019-07-24 14:17:16 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Module-Build-Using-PkgConfig

Comment 3 Jitka Plesnikova 2019-07-24 14:40:58 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.