Spec URL: https://jplesnik.fedorapeople.org/perl-Convert-Color-XTerm/perl-Convert-Color-XTerm.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Convert-Color-XTerm/perl-Convert-Color-XTerm-0.05-1.fc31.src.rpm Description: This subclass of Convert::Color::RGB8 provides lookup of the colors that xterm uses by default. Note that the module is not intelligent enough to actually parse the XTerm configuration on a machine, nor to query a running terminal for its actual colors. It simply implements the colors that are present as defaults in the XTerm source code. Fedora Account System Username: jplesnik
Url and Source0 addresses are Ok. Source0 archive (SHA-256: eac0939d9677b8e161fb96d087c04a91d5f9041a542822e69209d3f79c8cedb2) is original. Ok. Summary verified from lib/Convert/Color/XTerm.pm Ok. Descritpion verified from lib/Convert/Color/XTerm.pm Ok. License verified from lib/Convert/Color/XTerm.pm, LICENSE, Build.PL. Ok. No XS code, noarch BuildArch is Ok. TODO: I recommend using Makefile.PL instead of Build.PL. ExtUtils::MakeMaker is maintained, more advanced and has less dependencies. perl(Convert::Color::X11) is an optional dependency. Ok. FIX: Convert::Color is not used by the code. Do not build-require it and move the version constraint to perl(Convert::Color::RGB8). Test::Pod is an optional test. Ok. TODO: Package ./examples as a documentation All tests pass. Ok. $ rpmlint perl-Convert-Color-XTerm.spec ../SRPMS/perl-Convert-Color-XTerm-0.05-1.fc31.src.rpm ../RPMS/noarch/perl-Convert-Color-XTerm-0.05-1.fc31.noarch.rpm perl-Convert-Color-XTerm.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Convert-Color-XTerm/LICENSE 2 packages and 1 specfiles checked; 1 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Convert-Color-XTerm-0.05-1.fc31.noarch.rpm drwxr-xr-x 2 root root 0 Jul 24 15:27 /usr/share/doc/perl-Convert-Color-XTerm -rw-r--r-- 1 root root 494 Sep 17 2010 /usr/share/doc/perl-Convert-Color-XTerm/Changes -rw-r--r-- 1 root root 1321 Sep 17 2010 /usr/share/doc/perl-Convert-Color-XTerm/README drwxr-xr-x 2 root root 0 Jul 24 15:27 /usr/share/licenses/perl-Convert-Color-XTerm -rw-r--r-- 1 root root 18321 Sep 17 2010 /usr/share/licenses/perl-Convert-Color-XTerm/LICENSE -rw-r--r-- 1 root root 2497 Jul 24 15:27 /usr/share/man/man3/Convert::Color::XTerm.3pm.gz drwxr-xr-x 2 root root 0 Jul 24 15:27 /usr/share/perl5/vendor_perl/Convert drwxr-xr-x 2 root root 0 Jul 24 15:27 /usr/share/perl5/vendor_perl/Convert/Color -rw-r--r-- 1 root root 4162 Jul 24 15:27 /usr/share/perl5/vendor_perl/Convert/Color/XTerm.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Convert-Color-XTerm-0.05-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(base) 1 perl(Carp) 1 perl(Convert::Color) >= 0.06 1 perl(Convert::Color::RGB8) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Convert::Color is not used by the code. Do not build-require it and move the version constraint to perl(Convert::Color::RGB8). $ rpm -q --provides -p ../RPMS/noarch/perl-Convert-Color-XTerm-0.05-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(Convert::Color::XTerm) = 0.05 1 perl-Convert-Color-XTerm = 0.05-1.fc31 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Convert-Color-XTerm-0.05-1.fc31.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36460286). Ok. Otherwise the package is line with Fedora and Perl packaging guide lines. Please correct the 'FIX' items and consider fixing 'TODO' items before building this package. Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Convert-Color-XTerm
I imported the package and applied the changes requested in this review.