Bug 1733357 - missing gtk stock refresh icon in banshee "Devices" window
Summary: missing gtk stock refresh icon in banshee "Devices" window
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: banshee
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-25 19:41 UTC by Fabrice Bellet
Modified: 2019-07-25 19:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
Fix reference to gtk stock icons (1.25 KB, application/mbox)
2019-07-25 19:41 UTC, Fabrice Bellet
no flags Details
Fix CollectionExtensions disambiguation (1.00 KB, patch)
2019-07-25 19:45 UTC, Fabrice Bellet
no flags Details | Diff

Description Fabrice Bellet 2019-07-25 19:41:19 UTC
Created attachment 1593508 [details]
Fix reference to gtk stock icons

Hi!

I noticed that the gtk stock icon "refresh" has disappeared from banshee gui, in the window related to external devices. There's is a "Disconnect" action associated to the media-eject icon, and a "Sync" action associated to the gtk stock icon refresh that is replaced by the "icon missing" icon.

According to my tests, it seems to be caused by the addition of the icon in DapAction.cs *after* the creation of the ActionEntry(). The attached patch works for me.

As far as I remember, it worked fine in Fedora 29.

Comment 1 Fabrice Bellet 2019-07-25 19:45:53 UTC
Created attachment 1593510 [details]
Fix CollectionExtensions disambiguation

If it may help, I also need this other patch to build banshee from source on my Fedora 30. It seems there's an ambiguity for the definition of CollectionExtensions:

./Banshee.Preferences/Collection.cs(49,21): error CS0104: `CollectionExtensions' is an ambiguous reference between `System.Collections.Generic.CollectionExtensions' and `Hyena.Collections.CollectionExtensions'
/usr/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error)
/home/bellet/Development/banshee/src/Core/Banshee.Services/../../../bin/Hyena.dll (Location of the symbol related to previous error)
./Banshee.Preferences/Collection.cs(49,42): error CS0117: `System.Collections.Generic.CollectionExtensions' does not contain a definition for `SortedInsert'
/usr/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error)


Note You need to log in before you can comment on or make changes to this bug.