Spec URL: http://oirase.annexia.org/reviews/ocaml-seq/ocaml-seq.spec SRPM URL: http://oirase.annexia.org/reviews/ocaml-seq/ocaml-seq-0.1-1.fc30.src.rpm Description: Compatibility package for OCaml's standard iterator type Fedora Account System Username: rjones
I opened an issue upstream to get them to add a license file: https://github.com/c-cube/seq/issues/4 Here is a successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36727496
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - META is installed twice (by both the main package and the devel package): $ rpmls results/ocaml-seq-devel-0.1-1.fc31.x86_64.rpm -rw-r--r-- /usr/lib64/ocaml/seq/META $ rpmls results/ocaml-seq-0.1-1.fc31.x86_64.rpm ... -rw-r--r-- /usr/lib64/ocaml/seq/META It seems like it should probably only be installed once? Most OCaml packages seem to just install it in the main package. - rpmlint complains that seq.ml is packaged in ocaml-seq: ocaml-seq.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/seq/seq.ml It seems like the standard fedora policy is to remove the ML files, unless they happen to be necessary (in which case maybe they belong in the -devel package)? Everything else looks alright. One extra thing I noticed: - Licensing. You might want to add in the ticket you filed that the included seq.opam file claims the license to be "GPL": > license: "GPL" Though the source files have the "LGPLv2+ with exceptions" clause, so I think that's the right license to put in the spec. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [-]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/bjr/1735629-ocaml-seq/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml- seq , ocaml-seq-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-seq-0.1-1.fc31.x86_64.rpm ocaml-seq-devel-0.1-1.fc31.x86_64.rpm ocaml-seq-debuginfo-0.1-1.fc31.x86_64.rpm ocaml-seq-debugsource-0.1-1.fc31.x86_64.rpm ocaml-seq-0.1-1.fc31.src.rpm ocaml-seq.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/seq/seq.ml ocaml-seq-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: ocaml-seq-debuginfo-0.1-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). ocaml-seq-debuginfo.x86_64: W: invalid-url URL: https://github.com/c-cube/seq <urlopen error [Errno -2] Name or service not known> ocaml-seq-devel.x86_64: W: invalid-url URL: https://github.com/c-cube/seq <urlopen error [Errno -2] Name or service not known> ocaml-seq-devel.x86_64: W: no-documentation ocaml-seq-debugsource.x86_64: W: invalid-url URL: https://github.com/c-cube/seq <urlopen error [Errno -2] Name or service not known> ocaml-seq.x86_64: W: invalid-url URL: https://github.com/c-cube/seq <urlopen error [Errno -2] Name or service not known> ocaml-seq.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/seq/seq.ml 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Source checksums ---------------- https://github.com/c-cube/seq/archive/0.1.tar.gz : CHECKSUM(SHA256) this package : 193d104492079f5440cc9ee2a94d185631bfc47c9e17b5c4cf7d891053138b0a CHECKSUM(SHA256) upstream package : 193d104492079f5440cc9ee2a94d185631bfc47c9e17b5c4cf7d891053138b0a Requires -------- ocaml-seq (rpmlib, GLIBC filtered): libc.so.6()(64bit) ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__seq) ocaml(runtime) rtld(GNU_HASH) ocaml-seq-devel (rpmlib, GLIBC filtered): ocaml-seq ocaml-seq-debuginfo (rpmlib, GLIBC filtered): ocaml-seq-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-seq: ocaml(Seq) ocaml-seq ocaml-seq(x86-64) ocaml-seq-devel: ocaml-seq-devel ocaml-seq-devel(x86-64) ocaml-seq-debuginfo: debuginfo(build-id) ocaml-seq-debuginfo ocaml-seq-debuginfo(x86-64) ocaml-seq-debugsource: ocaml-seq-debugsource ocaml-seq-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1735629 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Ocaml, Generic Disabled plugins: Python, PHP, SugarActivity, R, Perl, Haskell, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: http://oirase.annexia.org/reviews/ocaml-seq/ocaml-seq.spec SRPM URL: http://oirase.annexia.org/reviews/ocaml-seq/ocaml-seq-0.1-2.fc30.src.rpm Description: Compatibility package for OCaml's standard iterator type Fedora Account System Username: rjones I believe I have fixed everything. We're still packaging the *.ml{,i}.depends files which TBH I've never seen before and I don't know what they do, but they appear to do no harm. Here are the changes: * Thu Aug 1 2019 Richard W.M. Jones <rjones> - 0.1-2 - Add a link to upstream bug about the license. - Don't install seq.ml file. - Don't package META twice.
Great, package is APPROVED.
Thanks. SCM and branch requests are here: https://pagure.io/releng/fedora-scm-requests/issue/14676 https://pagure.io/releng/fedora-scm-requests/issue/14677 https://pagure.io/releng/fedora-scm-requests/issue/14678
Ben do you think you could click "take" on this bug? The SCM requests were all denied because of this trivial bit of procedure.
Whoops. Done.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-seq
https://koji.fedoraproject.org/koji/taskinfo?taskID=36738155 I'll sort out ocaml-re and the rest of the packages.