Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcertificate.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.src.rpm Description: ZCertificate parses X.509 certificates and runs ZLint. Fedora Account System Username: eclipseo
Hello Robert-André, I have reviewed this package. This packages SHOULD contain a manpage for /usr/bin/zcertificate. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages ``` golang-github-zmap-zcertificate.x86_64: W: no-manual-page-for-binary ``` Here are the results of rpmlint. ``` $ rpmlint ~/rpmbuild/SRPMS/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.src.rpm && rpmlint ~/rpmbuild/RPMS/noarch/golang-github-zmap-zcertificate-devel-0-0.1.20190801git30e3881.fc31.noarch.rpm && rpmlint ~/rpmbuild//RPMS/x86_64/golang-github-zmap-zcertificate-debugsource-0-0.1.20190801git30e3881.fc31.x86_64.rpm && rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-zmap-zcertificate-debuginfo-0-0.1.20190801git30e3881.fc31.x86_64.rpm && rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. golang-github-zmap-zcertificate-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zcertificate/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 1 packages and 0 specfiles checked; 0 errors, 0 warnings. golang-github-zmap-zcertificate.x86_64: W: no-manual-page-for-binary zcertificate 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` Koji scratch build is failed because "golang(github.com/zmap/zlint)" was not found. However I successfully built the binary packages and installed them in my environment(Fedora-Rawhide-20190811.n.1 compose) where golang(github.com/zmap/zlint) exists and I have reviewed this package there. So I think the following error could be ignored. ``` ERROR: Command failed: # /usr/bin/dnf builddep --installroot /var/lib/mock/f31-build-17250474-1238749/root/ --setopt=install_weak_deps=0 --disableplugin=local --disableplugin=spacewalk /var/lib/mock/f31-build-17250474-1238749/root//builddir/build/SRPMS/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.src.rpm --setopt=tsflags=nocontexts Last metadata expiration check: 0:00:01 ago on Thu Aug 15 03:55:24 2019. No matching package to install: 'golang(github.com/zmap/zlint)' Not all dependencies satisfied Error: Some packages could not be found. ``` https://kojipkgs.fedoraproject.org//work/tasks/7575/37047575/mock_output.log Thanks in advance, Hirotaka Wakabayahsi
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcertificate.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.src.rpm
I've added the man page. I've built zlint of Rawhide (F32), it should be available in the "local" repo.
Hello Robert-André, The %install phase of building a binary package is failing while executing check-buildroot. ``` $ rpmbuild -ba golang-github-zmap-zcertificate.spec ... + /usr/lib/rpm/check-rpaths + /usr/lib/rpm/check-buildroot /home/vagrant/rpmbuild/BUILDROOT/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64/usr/share/man/man1/zcertificate.1:.SS "Usage of /home/vagrant/rpmbuild/BUILDROOT/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64/usr/bin/zcertificate:" /home/vagrant/rpmbuild/BUILDROOT/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64/usr/share/man/man1/zcertificate.1:.SS "Usage of /home/vagrant/rpmbuild/BUILDROOT/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64/usr/bin/zcertificate:" Found '/home/vagrant/rpmbuild/BUILDROOT/golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64' in installed files; aborting error: Bad exit status from /var/tmp/rpm-tmp.gHIiNa (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.gHIiNa (%install) ``` I think the "zcertificate.1" file under the buildroot should be "zcertificate.1.gz". I found man page files under buildroot In other packages like golang-github-zmap-zlint are gzipped but I don't know why the zcertificate's one is not gzipped... Thanks in advance, Hirotaka Wakabayashi
Tried to fix the man paqe. Seems help2man doesn't like when --version-string is 0.
A successful Koji scratch Build. https://koji.fedoraproject.org/koji/taskinfo?taskID=37088024
Hello Robert-André, Thanks for your fixing the problem. I successfully built binary packages. I found a new warning of rpmlint. Please check the following warning. ``` golang-github-zmap-zcertificate.x86_64: W: incoherent-version-in-changelog 0-0.1.20190816git30e3881 ['0-0.1.20190801git30e3881.fc31', '0-0.1.20190801git30e3881'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. ``` Here are the rpmlint results: ``` $ for file in $(find ~/rpmbuild/RPMS/ -type f); do echo $(basename $file); rpmlint $file; done golang-github-zmap-zcertificate-devel-0-0.1.20190801git30e3881.fc31.noarch.rpm golang-github-zmap-zcertificate-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zcertificate/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64.rpm golang-github-zmap-zcertificate.x86_64: W: incoherent-version-in-changelog 0-0.1.20190816git30e3881 ['0-0.1.20190801git30e3881.fc31', '0-0.1.20190801git30e3881'] 1 packages and 0 specfiles checked; 0 errors, 1 warnings. golang-github-zmap-zcertificate-debuginfo-0-0.1.20190801git30e3881.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. golang-github-zmap-zcertificate-debugsource-0-0.1.20190801git30e3881.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` Thanks in advance, Hirotaka Wakabayashi
(In reply to Hirotaka Wakabayashi from comment #8) > Hello Robert-André, > > Thanks for your fixing the problem. I successfully built binary packages. I > found a new warning of rpmlint. Please check the following warning. > ``` > golang-github-zmap-zcertificate.x86_64: W: incoherent-version-in-changelog > 0-0.1.20190816git30e3881 ['0-0.1.20190801git30e3881.fc31', > '0-0.1.20190801git30e3881'] > The latest entry in %changelog contains a version identifier that is not > coherent with the epoch:version-release tuple of the package. > ``` > > Here are the rpmlint results: > ``` > $ for file in $(find ~/rpmbuild/RPMS/ -type f); do echo $(basename $file); > rpmlint $file; done > golang-github-zmap-zcertificate-devel-0-0.1.20190801git30e3881.fc31.noarch. > rpm > golang-github-zmap-zcertificate-devel.noarch: W: hidden-file-or-dir > /usr/share/gocode/src/github.com/zmap/zcertificate/.goipath > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > golang-github-zmap-zcertificate-0-0.1.20190801git30e3881.fc31.x86_64.rpm > golang-github-zmap-zcertificate.x86_64: W: incoherent-version-in-changelog > 0-0.1.20190816git30e3881 ['0-0.1.20190801git30e3881.fc31', > '0-0.1.20190801git30e3881'] > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > golang-github-zmap-zcertificate-debuginfo-0-0.1.20190801git30e3881.fc31. > x86_64.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > golang-github-zmap-zcertificate-debugsource-0-0.1.20190801git30e3881.fc31. > x86_64.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > ``` > > Thanks in advance, > Hirotaka Wakabayashi This is not a problem: the date computed in ?dist is the date of creation of the archive, so i will change the date to the date of when I upload the archive to dist-git.
Hello Robert-André, I see. Thanks for your information. Package Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zmap-zcertificate