Bug 1737059 - Review Request: perl-Module-Package-RDF - Drive your distribution with RDF
Summary: Review Request: perl-Module-Package-RDF - Drive your distribution with RDF
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1737088
TreeView+ depends on / blocked
 
Reported: 2019-08-02 13:31 UTC by Petr Pisar
Modified: 2019-08-05 14:25 UTC (History)
2 users (show)

Fixed In Version: perl-Module-Package-RDF-0.014-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-05 14:25:22 UTC
Type: ---
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-08-02 13:31:43 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Module-Package-RDF/perl-Module-Package-RDF.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Package-RDF/perl-Module-Package-RDF-0.014-1.fc31.src.rpm
Description:
This is a build system for Perl modules defined by RDF.

Fedora Account System Username: ppisar

Comment 1 Robert-André Mauchin 🐧 2019-08-02 20:03:40 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 174609487b14f8db96baf1bbd06ad9454bae40e2f41a3a5113f83e722ebda916) is original. Ok.
Summary verified from lib/Module/Package/RDF.pm. Ok.
Description verified from lib/Module/Package/RDF.pm. Ok.
License verified from lib/Module/Package/RDF.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

$ rpmlint perl-Module-Package-RDF.spec review-perl-Module-Package-RDF/results/perl-Module-Package-RDF-0.014-1.fc31.noarch.rpm review-perl-Module-Package-RDF/results/perl-Module-Package-RDF-0.014-1.fc31.src.rpm 
perl-Module-Package-RDF.noarch: W: no-manual-page-for-binary mkdist
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpm -q -lv -p perl-Module-Package-RDF-0.014-1.fc31.noarch.rpm        21:51:09
-rwxr-xr-x    1 root    root                     2446 Aug  2 21:48 /usr/bin/mkdist
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/doc/perl-Module-Package-RDF
-rw-r--r--    1 root    root                     2767 Jul 31  2013 /usr/share/doc/perl-Module-Package-RDF/CONTRIBUTING
-rw-r--r--    1 root    root                     2218 Aug  2 21:48 /usr/share/doc/perl-Module-Package-RDF/COPYRIGHT
-rw-r--r--    1 root    root                      162 Aug  2 21:48 /usr/share/doc/perl-Module-Package-RDF/CREDITS
-rw-r--r--    1 root    root                     2560 Aug  2 21:48 /usr/share/doc/perl-Module-Package-RDF/Changes
-rw-r--r--    1 root    root                     1408 Aug  2 21:48 /usr/share/doc/perl-Module-Package-RDF/README
-rw-r--r--    1 root    root                       26 Jul  4  2012 /usr/share/doc/perl-Module-Package-RDF/TODO
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/licenses/perl-Module-Package-RDF
-rw-r--r--    1 root    root                    18406 Aug  2 21:48 /usr/share/licenses/perl-Module-Package-RDF/LICENSE
-rw-r--r--    1 root    root                     1663 Aug  2 21:48 /usr/share/man/man3/App::mkdist.3pm.gz
-rw-r--r--    1 root    root                     1875 Aug  2 21:48 /usr/share/man/man3/Module::Package::RDF.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/App
-rw-r--r--    1 root    root                     9742 Jul 31  2013 /usr/share/perl5/vendor_perl/App/mkdist.pm
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/Module
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/Module/Install
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/Module/Install/Admin
-rw-r--r--    1 root    root                     1171 Jul 31  2013 /usr/share/perl5/vendor_perl/Module/Install/Admin/StandardDocuments.pm
-rw-r--r--    1 root    root                      396 Jul 31  2013 /usr/share/perl5/vendor_perl/Module/Install/StandardDocuments.pm
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/Module/Package
drwxr-xr-x    2 root    root                        0 Aug  2 21:48 /usr/share/perl5/vendor_perl/Module/Package/Dist
-rw-r--r--    1 root    root                     1055 Jul 31  2013 /usr/share/perl5/vendor_perl/Module/Package/Dist/RDF.pm
-rw-r--r--    1 root    root                     4314 Jul 31  2013 /usr/share/perl5/vendor_perl/Module/Package/RDF.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Module-Package-RDF-0.014-1.fc31.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(base)
      1 perl(Carp)
      1 perl(DateTime)
      1 perl(File::HomeDir)
      1 perl(Getopt::ArgvFile)
      1 perl(Getopt::Long)
      1 perl(IO::All)
      1 perl(Log::Log4perl) >= 0
      1 perl(Module::Install::AutoInstall) >= 0
      1 perl(Module::Install::AutoLicense) >= 0.08
      1 perl(Module::Install::AutoManifest) >= 0
      1 perl(Module::Install::Base) >= 1.04
      1 perl(Module::Install::Copyright) >= 0.009
      1 perl(Module::Install::Credits) >= 0.009
      1 perl(Module::Install::DOAP) >= 0.006
      1 perl(Module::Install::DOAPChangeSets) >= 0.206
      1 perl(Module::Install::RDF) >= 0.009
      1 perl(Module::Install::ReadmeFromPod) >= 0.12
      1 perl(Module::Install::StandardDocuments)
      1 perl(Module::Install::TrustMetaYml) >= 0.003
      1 perl(Module::Package) >= 0.30
      1 perl(Module::Package::Plugin)
      1 perl(Moo)
      1 perl(RDF::TriN3) >= 0.201
      1 perl(RDF::Trine) >= 0.135
      1 perl(Software::License)
      1 perl(strict)
      1 perl(Text::Template)
      1 perl(URI::Escape)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Module-Package-RDF-0.014-1.fc31.noarch.rpm 
perl(App::mkdist) = 0.014
perl(Module::Install::Admin::StandardDocuments) = 0.014
perl(Module::Install::StandardDocuments) = 0.014
perl(Module::Package::Dist::RDF) = 0.014
perl(Module::Package::Dist::RDF::standard) = 0.014
perl(Module::Package::Dist::RDF::tobyink) = 0.014
perl(Module::Package::RDF) = 0.014
perl(Module::Package::RDF::standard) = 0.014
perl(Module::Package::RDF::tobyink) = 0.014
perl-Module-Package-RDF = 0.014-1.fc31
Binary provides are Ok.

Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=36766212).
Ok


Resolution: Package approved.

Comment 2 Gwyn Ciesla 2019-08-05 13:34:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Module-Package-RDF

Comment 3 Petr Pisar 2019-08-05 14:25:22 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.