Bug 1743116 - zeal displays ads on the startpage
Summary: zeal displays ads on the startpage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: zeal
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-19 06:46 UTC by Evgeni Golov
Modified: 2019-08-29 22:05 UTC (History)
2 users (show)

Fixed In Version: zeal-0.6.1-4.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-29 22:05:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot (19.49 KB, image/png)
2019-08-19 06:46 UTC, Evgeni Golov
no flags Details

Description Evgeni Golov 2019-08-19 06:46:34 UTC
Created attachment 1605640 [details]
screenshot

Description of problem:
Zeal as installed from Fedora displays ads after startup. IMHO it should not and instead respect my privacy.

Version-Release number of selected component (if applicable):
0.6.1-1.fc29

How reproducible:
100%

Steps to Reproduce:
1. start zeal

Actual results:
displays ads

Expected results:
does not display ads

Additional info:

Comment 1 Lumír Balhar 2019-08-19 08:43:30 UTC
Thank you for the bug.

From the upstream conversation [0] it seems that the ads will be removed in the release 0.7.0 and the change is already implemented [1]. We can also revert the commit where the ads were added [2]. There is also a setting option to disable ads on the welcome page in Edit → Preferences → Content.

[0] https://github.com/zealdocs/zeal/issues/779
[1] https://github.com/zealdocs/zeal/commit/680a1baa701581fdf5fcd92e3c2510e136666d3f
[2] https://github.com/zealdocs/zeal/commit/a90fef36dfa970427bf879b998897e95cafeeff1

Do you think that it's worth to remove it now or can we wait for the next release?

Comment 2 Evgeni Golov 2019-08-19 09:09:11 UTC
Hi,

thanks for acting quickly on this BZ!

I think this highly depends on when you expect 0.7.x to land in Fedora. If it's next week, then there is absolutely no reason to try to remove this ourself today. But if it's months away, I'd probably look into disabling the ads in Fedora.

How you do it (reverting the original commit, cherry-picking the removal commit, or just patching the setting to be "true" by default) I as a pure user don't care :)

Evgeni

Comment 3 Fedora Update System 2019-08-20 13:04:55 UTC
FEDORA-2019-6e07532b99 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6e07532b99

Comment 4 Lumír Balhar 2019-08-20 13:07:08 UTC
In the most recent build of zeal (0.6.1-4) the ads on the welcome page are disabled by default.

I've tested it in the live virtual environment and a fresh install seems to be without ads.

Comment 5 Fedora Update System 2019-08-21 01:21:18 UTC
zeal-0.6.1-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6e07532b99

Comment 6 Fedora Update System 2019-08-29 22:05:49 UTC
zeal-0.6.1-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.