Description of problem:

OperatorSources with authorization tokens generate bad operator-registry deployments.

Version-Release number of selected component (if applicable):

4.1 (probably 4.1.11 from original report)

How reproducible:

Always

Steps to Reproduce:

apiVersion: v1
kind: Secret
metadata:
  name: brew-operators-secret
  namespace: openshift-marketplace
type: Opaque
stringData:
  token: "basic secretgoeshere"
---
apiVersion: operators.coreos.com/v1
kind: OperatorSource
metadata:
  name: brew-stage-operators
  namespace: openshift-marketplace
spec:
  type: appregistry
  endpoint: https://quay.io/cnr
  registryNamespace: rh-osbs-operators
  displayName: "Brew Operators"
  publisher: "Brew"
  authorizationToken:
    secretName: brew-operators-secret


Actual results:

the resulting deployment has wrong "--registry" argument for the appregistry command: "--registry=https://quay.io/cnr%7Cddolguik --registry=https://quay.io/cnr%7Crh-osbs-operators%7Copenshift-marketplace/brew-operators-secret". Note the extra "ddolguik --registry=https://quay.io/cnr".

Expected results:

the resulting deployment has the correct registry argument and pulls down private packages.


Additional info: