Bug 1753808 - broken after update to python-html2text 2019.8.11
Summary: broken after update to python-html2text 2019.8.11
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rss2email
Version: 30
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-19 23:29 UTC by Jakob Hirsch
Modified: 2019-10-06 00:56 UTC (History)
4 users (show)

Fixed In Version: rss2email-2.71-16.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-06 00:56:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jakob Hirsch 2019-09-19 23:29:54 UTC
Description of problem:

r2e uses the html2text's unescape() method, but this was removed in 2019.8.11 (because "unused"), see https://github.com/Alir3z4/html2text/releases/tag/2019.8.11

Version-Release number of selected component (if applicable):

rss2email-2.71-14.fc29.noarch
python2-html2text-2019.8.11-1.fc30.noarch

How reproducible:

always

Steps to Reproduce:
1. install rss2email
2. add feed, e.g. `r2e add https://www.schneier.com/blog/atom.xml`
3. `r2e run`

Actual results:

$ r2e run
=== rss2email encountered a problem with this feed ===
=== See the rss2email FAQ at http://www.allthingsrss.com/rss2email/ for assistance ===
=== If this occurs repeatedly, send this to lindsey ===
E: could not parse https://www.schneier.com/blog/atom.xml
Traceback (most recent call last):
  File "/usr/share/rss2email/rss2email.py", line 683, in run
    name = h2t.unescape(getName(r, entry))
AttributeError: 'module' object has no attribute 'unescape'
rss2email 2.71
feedparser 5.2.1
html2text (2019, 8, 11)
Python 2.7.16 (default, Apr 30 2019, 15:54:43)
[GCC 9.0.1 20190312 (Red Hat 9.0.1-0.10)]
=== END HERE ===

Expected results:

$ r2e run
(no errors)

Additional info:

After manually downgrading to html2text-2018.1.9-1, r2e runs fine again.
I know r2e is somewhat outdated (last update 2011) and there are plans to replace it with one of it's forks (e.g. #1738816).
I also opened an issue for html2text: https://github.com/Alir3z4/html2text/issues/291

Comment 1 David Kaufmann 2019-09-20 14:31:15 UTC
I'm currently waiting for my sponsor to actually be confirmed as sponsor that I can get assigned as packager.
Right now I can only point you to a 3.10 build on copr without the bug:

https://copr.fedorainfracloud.org/coprs/astra/rss2email/build/1030281/

I've also built the 3.9 version there, but that has the same problem, as it still uses unescape from html2text.

Comment 2 Dave Dykstra 2019-09-26 18:24:40 UTC
Ah, but the epel7 builds on copr have all failed.

The workaround I went with for now was to downgrade python2-html2text:


# yum downgrade https://dl.fedoraproject.org/pub/archive/epel/7/x86_64/Packages/p/python2-html2text-2016.9.19-1.el7.noarch.rpm

Comment 3 Fedora Update System 2019-09-27 01:38:46 UTC
FEDORA-2019-ae09a9038d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae09a9038d

Comment 4 David Kaufmann 2019-09-27 01:46:16 UTC
For epel7 the update should be here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bbf381ba00

Please test, I've mainly tested the fc30-version.

These updates include the code from html2text right before unescape was removed.

Comment 5 Dave Dykstra 2019-09-27 15:05:27 UTC
It stops the crash for me, thanks.

Comment 6 Fedora Update System 2019-09-28 01:20:52 UTC
rss2email-2.71-16.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae09a9038d

Comment 7 Fedora Update System 2019-10-06 00:56:28 UTC
rss2email-2.71-16.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.