Spec Name or Url: http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex.spec SRPM Name or Url: http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex-0.1.3-1.src.rpm Description: I have made an RPM for kbibtex to be reviewed. KBibTeX is a KDE BiBTeX Editor written by Thomas Fischer. See http://www.unix-ag.uni-kl.de/~fischer/kbibtex This is my first contribution so I need a sponsor please.
* Source0 needs to specify full URL * you mix tabs and space so that it looks pretty strange in the browser and in my editor * qt-devel is already required by kdebase-devel * have a look at other KDE/QT spec files in Fedora Extras to see what they do with QTDIR and friends * You don't have to specify "--prefix=%{_prefix}" for %configure * The icon doesn't show up in the gnome menu; you have to update the icon cache (see Scriptlets page in wiki) * the package has to own at least following directories: %{_datadir}/apps/kbibtexpart/ %{_datadir}/apps/kbibtex/ %{_docdir}/HTML/en/kbibtex/
Thank you for reviewing my package. I have fixed the problems. Furthermore I have added a workaround for the icons which are installed as crystalsvg icons, which prevents the icons from being visible when some other iconset is used in gnome. I will contact the author about this issue. Spec file: http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex.spec SRPM: http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex-0.1.3-2.src.rpm
This builds in "mock -r fedora-4-i386-core" but not in "mock -r fedora-development-i386-core". As the devel branch is the first it is imported into it should build also there. So it would be great if you change if to build in that branch. There are now a lot of uncommented lines which make the spec a bit unreadable. It ould be better, from my point of view, if the unused lines are removed. General comments are no problem just lines like "#%{_datadir}/apps/kbibtex/kbibtex_shell.rc" have no real value.
Are you really getting build errors with development, or just trouble constructing the root it the first place? Rawhide is churning a lot lately. Today I get a missing dependency for mesa-libGL - won't work until that at least is rebuilt.
as development is broken I did test it on 5test1: mock -r fedora-5test1-i386-core kbibtex-0.1.3-2.src.rpm checking for vsnprintf... yes checking for snprintf... yes checking for X... configure: error: Can't find X includes. Please check your installation and add the correct paths! error: Bad exit status from /var/tmp/rpm-tmp.31289 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.31289 (%build)
Ah, modular X changes! In this case I would argue that once your get sponsorship aproval (Adrian - can you sponsor someone?) that you check in what you have and request an FC-4 (and possibly FC3 if you want to maintain that) branch. Then you can start hacking the devel branch to work with modular X. With kdesvn I ended up putting in a patch to configure to completely remove the configure checks for X includes and libraries as they are now in /usr/include and /usr/lib (or rather, %{_libdir}!). Other possibility is to get upstream to fix admin/acinclude.m4.in or replace with a newer version before initial checkin.
While I am waiting for a sponsorship, I will definitely try to get this package working within the devel branch. However, as I am new to these procedures I first have to get warm with mock & co.
I have set up a test-box where I have installed the latest FC5-devel distribution according to http://fedoraproject.org/wiki/Docs/Drafts/TestingGuide. I have also tested the kbibtex package on FC5-devel, updated today, without having any of the mentioned problems. The only thing I've encountered was a compile-error related to GCC 4.1.0 which I have fixed in the RPM. Perhaps you can verify this with the latest devel-versions. http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex.spec http://public.fh-wolfenbuettel.de/~noltec/open-source/kbibtex/kbibtex-0.1.3-3.src.rpm
I now did a "mock -r fedora-development-i386-core" and the SRPM works for me.
* builds in mock * clean installation and removal * source matches upstream * patch looks good * spec looks good * rpmlint is almost happy: W: kbibtex dangling-symlink /usr/share/doc/HTML/en/kbibtex/common /usr/share/doc/HTML/en/common W: kbibtex symlink-should-be-relative /usr/share/doc/HTML/en/kbibtex/common /usr/share/doc/HTML/en/common APPROVED As soon as you are ready to be sponsored I will do it.
I am ready to be sponsored. I have added a membership request for cvsextras to my user-account 'noltec'.
This package has been built cleanly within FC-4 and devel branches.
Package Change Request ====================== Package Name: kbibtex New Branches: epel7 Owners: cheeselee
Git done (by process-git-requests).