Bug 1756427 - Ability to do lvchange for vdo pool or vdo pool lv
Summary: Ability to do lvchange for vdo pool or vdo pool lv
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: lvm2
Version: 8.0
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: rc
: 8.0
Assignee: Zdenek Kabelac
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-27 15:31 UTC by Tony Asleson
Modified: 2021-09-07 11:52 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-01 19:46:29 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tony Asleson 2019-09-27 15:31:18 UTC
Description of problem:

man lvmvdo states:

Disable or enable compression and deduplication for VDO pool LV (the volume that maintains all VDO LV(s) associated with it).

lvchange --compression [y|n] --deduplication [y|n] VG/VDOPoolLV


However, you can do the lvchange by specifying the vdo pool lv or the
vdo lv created from the vdo pool lv.

Version-Release number of selected component (if applicable):
NA

How reproducible:
100 %

Steps to Reproduce:

[root@localhost ~]# lvchange --compression y VG_NAME/vdo_pool ; echo $?
  Logical volume VG_NAME/vdo_pool changed.
0
[root@localhost ~]# lvchange --compression n VG_NAME/vdo_lv ; echo $?
  Logical volume VG_NAME/vdo_lv changed.
0
[root@localhost ~]# lvchange --compression n VG_NAME/vdo_pool ; echo $?
  Logical volume VG_NAME/vdo_pool already uses --compression n.
5


Expected results:

Either an error that this is not supported on the vdo lv or that we
update the man page to stipulate that it's OK to do the lvchange on either.


Additional info:

Comment 1 Jonathan Earl Brassow 2020-09-17 14:50:35 UTC
will update man page

Comment 8 Zdenek Kabelac 2021-01-22 23:04:16 UTC
For this moment - the behavior is lvchange --compression & --deduplication  follows  i.e. setting of --permission rw|r.

If there is wanted some other logic - we need to open new bug about making options consistent in some way.

The original logic was to return error when setting already has the value set.
Over the time many setting slipped in with returning 0 when the option already had the value set and introduced large level
of inconsistency.

Basic inspiration I think come from aligning it with i.e.:
   'lvremove vg/lv'  - if such LV is already gone - user gets error.
   'lvcreate --name some_existing_name' - LV with existing name returns errors since already exists.

For current release of 8.4 - the feature is considered finished.

Comment 9 Zdenek Kabelac 2021-02-01 19:46:29 UTC
So if there is global request for a global consistency refresh - we need to open new RFE bug.


Note You need to log in before you can comment on or make changes to this bug.