Spec URL: https://www.cora.nwra.com/~orion/fedora/koan.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/koan-2.9.0-0.2.git.fc32.src.rpm Description: Koan stands for kickstart-over-a-network and allows for both network installation of new virtualized guests and reinstallation of an existing system. For use with a boot-server configured with Cobbler. https://koji.fedoraproject.org/koji/taskinfo?taskID=38229774 Fedora Account System Username: orion koan is once again getting split out of cobbler.
Are you interested in a review swap?
Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/koan See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names Maybe check why koan is orphaned since 9 years. It looks like an accident from scm migration. Consider to open a ticket to releng and clarify ownership.
As you intend to package the branch of version 2.x, we may to introduce koan2 then if there's no need to unorphan legacy koan (version 1.6.x).
(In reply to Raphael Groner from comment #1) > Are you interested in a review swap? Sure. It's been a while so I'm probably due :). Which one do you have in mind? I really think it's time to unretire koan. Development has been split out again from cobbler as it was (briefly) before.
(In reply to Raphael Groner from comment #3) > As you intend to package the branch of version 2.x, we may to introduce > koan2 then if there's no need to unorphan legacy koan (version 1.6.x). koan 1.x is dead, let it rest in peace. As Cobbler 3.x is "cobbler", koan 2.x can be "koan".
(In reply to Orion Poplawski from comment #4) > (In reply to Raphael Groner from comment #1) > > Are you interested in a review swap? > > Sure. It's been a while so I'm probably due :). Which one do you have in > mind? None at the moment ... Maybe I'll come back later for your offer. Thanks. Try to take a look into bug #1709037 (in active review already). > I really think it's time to unretire koan. Development has been split out > again from cobbler as it was (briefly) before. (In reply to Neal Gompa from comment #5) > (In reply to Raphael Groner from comment #3) > > As you intend to package the branch of version 2.x, we may to introduce > > koan2 then if there's no need to unorphan legacy koan (version 1.6.x). > > koan 1.x is dead, let it rest in peace. As Cobbler 3.x is "cobbler", koan > 2.x can be "koan". That sounds fair enough.
Ah, in cobbler.spec it tells: # koan is not yet available - to be re-introduced later ? # https://github.com/cobbler/cobbler/issues/2087 # Avoid to obsoletes koan in EL8 (from modules) %if 0%{?fedora} Obsoletes: koan < 3.0.0-1 %endif It's not really clear to me what is the actual difference between cobbler and koan and how the compatibility between both version branches can work.
What do you think about disabling SELinux as officially recommended in the quickstart tutorial of cobbler? Please give a statement. https://cobbler.github.io/manuals/quickstart/
*** Bug 1394906 has been marked as a duplicate of this bug. ***
Hmm, I need to get rid of that obsoletes in cobbler. They are just completely separate packages at this point. Unfortunately cobber and SELinux still don't entirely play well together. But it's not really relevant for koan since it's a separate thing. SELinux generally doesn't affect koan since it is usually run directly as root and hence is unconfined.
Ping?
At the moment, I can't continue with the review due to lack of time. Sorry.
I'll take this review.
> Version: 2.9.0 > Release: 0.2.git%{?dist} The snapshot versioning doesn't match our guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots Mainly, a short commit hash isn't present to identify what it was built from. > %package -n python%{python3_pkgversion}-koan > Summary: koan python%{python3_pkgversion} module > # Uses distutil so no automatic dependencies Koan uses setuptools as of 18df5d4f742d69c8b7343adfed0ebc795f581842, so you can rebase to that commit and drop all manually specified Python dependencies. You'll need to add a "BuildRequires: python3dist(setuptools)" dependency. > %setup -q -n %{name}-%{commit} Couldn't you use "%autosetup -n %{name}-%{commit}" instead?
Thanks. Spec URL: https://www.cora.nwra.com/~orion/fedora/koan.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/koan-2.9.0-0.5.20191115git18df5d4.el7.src.rpm * Fri Nov 15 2019 Orion Poplawski <orion> - 2.9.0-0.5.20191115git18df5d4 - Update to latest git - Use automatic python dependencies - Use proper snapshot release tag * Thu Nov 7 2019 Orion Poplawski <orion> - 2.9.0-0.4.git - Update to latest git * Fri Oct 18 2019 Orion Poplawski <orion> - 2.9.0-0.3.git - Add patch to support cobbler 2 servers - Add patch to fix quoting with grubby on EL8
Review notes: - Package follows Fedora Packaging Guidelines - Package follows Fedora Python Packaging Guidelines - Package builds and installs correctly - Package licensing is declared correctly PACKAGE APPROVED.
FEDORA-2019-5f71b88869 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5f71b88869
koan-2.9.0-0.5.20191115git18df5d4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.