Bug 176615 - dhcpd omits domainname when sending dynamic dns update
Summary: dhcpd omits domainname when sending dynamic dns update
Alias: None
Product: Fedora
Classification: Fedora
Component: dhcp   
(Show other bugs)
Version: 4
Hardware: All Linux
Target Milestone: ---
Assignee: Jason Vas Dias
QA Contact:
Depends On:
Blocks: 177963
TreeView+ depends on / blocked
Reported: 2005-12-27 17:24 UTC by Christoph Dworzak
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version: dhcp-3.0.2-30.FC4
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-05-01 17:22:33 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
logfile showing good and bad behaviour (2.22 KB, text/plain)
2005-12-27 17:27 UTC, Christoph Dworzak
no flags Details
tcpdump of dhcp client/server communication (7.46 KB, text/plain)
2006-01-14 17:46 UTC, Christoph Dworzak
no flags Details
(stripped) dhcpd.conf (602 bytes, text/plain)
2006-01-14 17:47 UTC, Christoph Dworzak
no flags Details
tcpdump of dhcp-server to dns-server traffic (13.39 KB, text/plain)
2006-01-14 17:58 UTC, Christoph Dworzak
no flags Details

Description Christoph Dworzak 2005-12-27 17:24:23 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7

Description of problem:
between dhcp-3.0.2-22 and dhcp-3.0.2-24 some code was moved around and i think this had an undesired side-effect. i tried to find the exact spot, but couldn't find it.

The release notes say:
>"append"ing a string onto the end of a "t" type option (such as the
>domain-name field) that had been improperly NULL-terminated by the
>DHCP server will no longer result in a truncated string containing
>only the option from the server, and not the expected appended value.

For me it has the opposite effect.
See the attached logfile.
Notice how 3.0.2-24 says only BOOLE while 3.0.2-22 says BOOLE.creaholic.com.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. set up a dhcp-server for dynamic dns updates
2. have a nt-client
3. in a dos-shell release ip ("ipconfig /release")
4. in a dos-shell renew ip ("ipconfig /renew")

Actual Results:  logfile on dhcp-server shows error:
Unable to add forward map from BOOLE to timed out

zonefiles on dns-server has no records for BOOLE

Expected Results:  logfile should show:
Added new forward map from BOOLE.creaholic.com. to
added reverse map from to BOOLE.creaholic.com.

zonefiles on dns-server should have forward and reverse records for BOOLE

Additional info:

notice in attached logfile how it uses the fqdn to remove the dns-records, but uses the hostname without domainname to add dns-records.

Comment 1 Christoph Dworzak 2005-12-27 17:27:02 UTC
Created attachment 122601 [details]
logfile showing good and bad behaviour

Comment 2 Jason Vas Dias 2006-01-09 18:55:35 UTC
I'm investigating this now. 
Did you try the latest dhcp-3.0.2-28.FC4 release now in updates/testing
(and being moved to updates/final today) ? This release has the complete 
upstream patch for the null termination issue.
It would also be most helpful if you could gather a tcpdump of the server/client
traffic on the server:
  # tcpdump -nl -i any -vvv -s 4096 -X port bootps or port bootpc \
    >/tmp/dhcp.tcpdump.log 2>&1
Then boot the client, duplicating the problem,  'pkill tcpdump', and append
the /tmp/dhcp.tcpdump.log contents to this bug report - thank you.

Comment 3 Jason Vas Dias 2006-01-09 21:49:58 UTC
I cannot reproduce this issue with dhcp-3.0.2-28.FC4, or with dhcp-3.0.1-52.EL4
in RHEL-4, both of which have the latest upstream fix for the trailing NUL
removal issue.

I was using a Windows-XP-Professional client, which had the option 
  "Register this connection's addresses in DNS" checked (selected) in the
"DNS" tab of the "Advanced TCP/IP Settings" dialog, reached by clicking on
the "Advanced" button of the "Internet Protocol (TCP/IP) Properties" dialog 
of the "Local Area Connection Properties" dialog. 

NOTE: Windows has several options regarding DDNS updates : 
  o "Append primary and connection specific DNS suffixes" -
    The "connection specific DNS suffix" comes from the DHCP 'domain-name'
    option, and is listed in the 'ipconfig' output.
    The "primary" suffix is the suffix of the primary DNS server (which may
    or may not be in the DHCP 'domain-name-servers' option).
  o "Append these DNS suffixes" -
    A list of domain name suffixes to update can be specified explicitly.
  o "DNS suffix for this connection" - 
    A DNS suffix can be explicitly specified for the connection.

Note also that the dhcp server can request the client to do the DNS updates
by sending the a 'fqdn.server-update' value of 0 (false) ( or by setting the
'allow client-updates' option ) (but I'm not sure how you'd tell windows about
the DNS zone keys).

If you still have problems with dhcp-3.0.2-28.FC4, please gather the tcpdump
output requested above, and send me it along with your dhcpd.conf file - 
thank you.

Comment 4 Jason Vas Dias 2006-01-13 16:14:59 UTC
Can you reproduce this problem with dhcp-3.0.2-28.FC4 ? I've not been able to.
If you can, please send me the tcpdump and dhcpd.conf data requested above,
and re-open this bug - thank you.

Comment 5 Christoph Dworzak 2006-01-14 17:46:15 UTC
Created attachment 123200 [details]
tcpdump of dhcp client/server communication

Comment 6 Christoph Dworzak 2006-01-14 17:47:08 UTC
Created attachment 123201 [details]
(stripped) dhcpd.conf

Comment 7 Christoph Dworzak 2006-01-14 17:53:45 UTC
Problem still persists with dhcp-3.0.2-28.FC4.
please note:
-dhcp-client ist windows nt (not xp)
-dhcp-server is set to do the ddns-update.
-the dhcp-client doesn't know anything about ddns.

Comment 8 Christoph Dworzak 2006-01-14 17:58:28 UTC
Created attachment 123202 [details]
tcpdump of dhcp-server to dns-server traffic

note how dhcpd sends only TAYLOR not taylor.creaholic.com to the dns.

Comment 9 Jason Vas Dias 2006-01-16 21:32:01 UTC
Many thanks for appending the client->server dhcp traffic - I've found and 
fixed the problem now.
This bug is fixed with dhcp-3.0.2-30.FC4, to be release to FC-4/Updates/Testing
today, and dhcp-3.0.3-20.FC5 in Rawhide.
Please try out the new version and let me know of any issues - thanks .

Comment 10 Fedora Update System 2006-01-16 21:46:11 UTC
From User-Agent: XML-RPC

dhcp-3.0.2-30.FC4 has been pushed for FC4, which should resolve this issue.  If these problems are still present in this version, then please make note of it in this bug report.

Comment 11 Fedora Update System 2006-01-24 03:21:19 UTC
From User-Agent: XML-RPC

dhcp-3.0.2-30.FC4 has been pushed for FC4, which should resolve this issue.  If these problems are still present in this version, then please make note of it in this bug report.

Comment 12 Christoph Dworzak 2006-01-25 20:33:04 UTC
we tested dhcp-3.0.2-30.FC4 and it seems to work fine.
thanks a lot for fixing it!

Note You need to log in before you can comment on or make changes to this bug.