Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4983/38654983/jaero-1.0.4.11-1.fc32.src.rpm Description: JAERO is a program that demodulates and decodes Classic Aero ACARS (Aircraft Communications Addressing and Reporting System) messages sent from satellites to aeroplanes (SatCom ACARS), commonly used when planes are beyond VHF range. Demodulation is performed using the soundcard. Such signals are typically around 1.5Ghz and can be received with a low-gain antenna that can be home-brewed in conjunction with an RTL-SDR dongle.
Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5473/38655473/jaero-1.0.4.11-1.fc32.src.rpm License corrected.
> Requires: unzip 1. Add %{?_isa}. > BuildRequires: kiss-fft-static 2. kiss-fft-devel > sed -i '/kiss_fft130\/kiss_fft/d' JAERO/JAERO.pro 3. Please replace multiple sed calls with a single one. > cd JAERO/build 4. I think it will be better to use pushd JAERO/build ... popd instead. 5, Please add AppData metafile and send it to upstream. 6. Add comments to used in project patches.
Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8574/38678574/jaero-1.0.4.11-2.fc32.src.rpm 1. Added %{?_isa} to unzip. 2. Gudelines say that need BR: ...-static https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries And because -devel provides static I set only one of them. 3. Multiple sed replaced. 4. Used pushd/popd. 5. I don't have AppData. 6. Comments to patches added.
The license is MIT and LGPLv2.1: ./JAERO/gui_classes/console.cpp: LGPL (v2.1 or v3) ./JAERO/gui_classes/console.h: LGPL (v2.1 or v3) > mkdir JAERO/build Can be moved to %prep. > I don't have AppData. You should add it manually and send pull request to upstream.
Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3088/38683088/jaero-1.0.4.11-2.fc32.src.rpm AppData added.
LGTM now. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jaero