Bug 1767347 - Refactor download and upload disk-snapshots python sdk code for consistency
Summary: Refactor download and upload disk-snapshots python sdk code for consistency
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: General
Version: 4.3.0
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Daniel Erez
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-31 09:04 UTC by Yosi Ben Shimon
Modified: 2021-11-12 09:55 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-29 09:27:13 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-37679 0 None None None 2021-08-29 09:29:57 UTC

Description Yosi Ben Shimon 2019-10-31 09:04:52 UTC
Description of problem:
Download [1] and upload [2] disk-snapshot should be more consistency as they are related to backup and restore operations.

Now, to be more specific:
1. download_disk_snapshots.py:
- Doesn't save the disks under "disks/" directory as appears in upload_disk_snapshots.py
- Doesn't save the OVF file required for the upload_disk_snapshots.py

2, upload_disk_snapshots.py:
- In this example, the disk_path (line 290) should be only "disks/".
- Doesn't work correctly when the VM has only one snapshot (missing parent) as the "Active_VM" is not being downloaded


[1] https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/download_disk_snapshots.py
[2] https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/upload_disk_snapshots.py

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
We need to modify the download_disk_snapshots.py so it will save the disks under "disks/" dir as well as save the OVF file.
We also need to modify the upload_disk_snapshots.py and set disk_path='disks/'


Expected results:


Additional info:

Comment 1 Eyal Shenitzky 2021-08-29 09:27:13 UTC
Python SDK examples shouldn't be treated as a product and consistency between two different examples is irrelevant.
Patches for changing the current behavior are welcome.

Closing this bug as WONTFIX.


Note You need to log in before you can comment on or make changes to this bug.