Bug 1768348 - [sriov] nodeselector should show by default in sriovoperatorconfigs when installed the sriov operator
Summary: [sriov] nodeselector should show by default in sriovoperatorconfigs when inst...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.3.0
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: 4.3.0
Assignee: zenghui.shi
QA Contact: zhaozhanqi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-04 07:07 UTC by zhaozhanqi
Modified: 2019-12-06 03:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-06 03:08:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description zhaozhanqi 2019-11-04 07:07:35 UTC
Description of problem:
After installed the sriov operator. the parameter 'configDaemonNodeSelector' did not be shown by default. we should add it into CR otherwise the user did not know there is this kind of parameter.

Version-Release number of selected component (if applicable):
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.4-201911010432-ose-sriov-network-operator

How reproducible:
always

Steps to Reproduce:
1. Install the sriov operator
2. Check sriovoperatorconfigs 

   #oc get sriovoperatorconfigs.sriovnetwork.openshift.io default -o yaml
apiVersion: sriovnetwork.openshift.io/v1
kind: SriovOperatorConfig
metadata:
  creationTimestamp: "2019-11-01T03:27:36Z"
  generation: 10
  name: default
  namespace: openshift-sriov-network-operator
  resourceVersion: "1374312"
  selfLink: /apis/sriovnetwork.openshift.io/v1/namespaces/openshift-sriov-network-operator/sriovoperatorconfigs/default
  uid: 970d1a98-2c6f-4d54-819e-ebf68baefac9
spec:
  enableInjector: true
  enableOperatorWebhook: true
3.

Actual results:

in step 2. no field for 'configDaemonNodeSelector' by default

Expected results:
should show 
'configDaemonNodeSelector' 
    "node-role.kubernetes.io/worker": "", 
    "beta.kubernetes.io/os":          "linux",

Additional info:

Comment 1 Peng Liu 2019-11-06 09:50:49 UTC
I don't think this should be a bug. If a user doesn't specify the 'configDaemonNodeSelector', then the config daemon will have a default nodeSelector, which let the daemon run on all worker nodes as we did in 4.2.

Comment 2 zhaozhanqi 2019-11-13 13:04:20 UTC
@Peng, IMO, since this is a new feature in 4.3. if we do not list the filed,maybe the customer do not know it. So I think better to list in sriovoperatorconfigs,just like enableInjector and enableOperatorWebhook


Note You need to log in before you can comment on or make changes to this bug.