* Test suite is not executed
  - Please execute test suite in %check section. It seems the RSpec test suite is included in package, so "rspec spec" could be enough to make it running.

I haven't included %check due to missing requires

+ pushd ./usr/share/gems/gems/hrx-1.0.0
~/development/rpmbuild/BUILD/hrx-1.0.0/usr/share/gems/gems/hrx-1.0.0 ~/development/rpmbuild/BUILD/hrx-1.0.0
+ rspec spec

An error occurred while loading ./spec/archive_spec.rb.
Failure/Error: require 'rspec/temp_dir'

LoadError:
  cannot load such file -- rspec/temp_dir
# ./spec/archive_spec.rb:16:in `<top (required)>'


Finished in 0.00018 seconds (files took 0.22822 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

(In reply to leigh scott from comment #2)
Jun covered this extensively here:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/372XSBBEB2ATBTENVLUVGXPJ3F55PU54/

koji scratch build

https://koji.fedoraproject.org/koji/taskinfo?taskID=39434394

> Spec URL: https://leigh123linux.fedorapeople.org/pub/review/rubygem-hrx/rubygem-hrx.spec

> # Move the tests into place
> ln -s %{_builddir}/spec spec

You can remove the 2 lines, as the Source0 (= hrx-1.0.0.gem) includes `spec/*_spec.rb files` in it.
The "spec" exists there without doing "ln -s ...".

Maybe the lines came from following examples I introduced you.
In the examples the each Source0 does not have the unit test files in it (= the gem file).
That's the reason why the lines were needed.
https://src.fedoraproject.org/rpms/rubygem-listen/blob/master/f/rubygem-listen.spec
https://src.fedoraproject.org/rpms/rubygem-rake/blob/master/f/rubygem-rake.spec


> rspec -rspec_helper spec

You do not need to add "-rspec_helper", as it is correctly required from each `*_spec.rb` file.

Referring the Ruby guideline, you can just replace it with "rspec -Ilib spec".
https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_rspec

> dot files.

I think that the dot files are for only development use like `.gitignore` as well.
Possibly you can change like this.

```
 %files
 %dir %{gem_instdir}
-%exclude %{gem_instdir}/.gitignore
+%exclude %{gem_instdir}/.*
 %license %{gem_instdir}/LICENSE
 %{gem_libdir}
 %exclude %{gem_cache}
@@ -64,8 +62,6 @@ popd
 
 %files doc
 %doc %{gem_docdir}
-%doc %{gem_instdir}/.rdoc_options
-%exclude %{gem_instdir}/.rspec
 %doc %{gem_instdir}/CONTRIBUTING.md
 %{gem_instdir}/Gemfile
 %doc %{gem_instdir}/README.md
```

For your information, seeing the upstream hrx project's CI setting file could be the clue to know how to run the unit test files in the RPM spec file.

In this case, here it is.

https://github.com/google/hrx-ruby/blob/master/.travis.yml#L16
> script: bundle exec rspec

(In reply to Jun Aruga from comment #5)
> > Spec URL: https://leigh123linux.fedorapeople.org/pub/review/rubygem-hrx/rubygem-hrx.spec
> 
> > # Move the tests into place
> > ln -s %{_builddir}/spec spec
> 
> You can remove the 2 lines, as the Source0 (= hrx-1.0.0.gem) includes
> `spec/*_spec.rb files` in it.
> The "spec" exists there without doing "ln -s ...".
> 
> Maybe the lines came from following examples I introduced you.
> In the examples the each Source0 does not have the unit test files in it (=
> the gem file).
> That's the reason why the lines were needed.
> https://src.fedoraproject.org/rpms/rubygem-listen/blob/master/f/rubygem-
> listen.spec
> https://src.fedoraproject.org/rpms/rubygem-rake/blob/master/f/rubygem-rake.
> spec
> 
> 
> > rspec -rspec_helper spec
> 
> You do not need to add "-rspec_helper", as it is correctly required from
> each `*_spec.rb` file.
> 
> Referring the Ruby guideline, you can just replace it with "rspec -Ilib
> spec".
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_rspec
> 
> > dot files.
> 
> I think that the dot files are for only development use like `.gitignore` as
> well.
> Possibly you can change like this.
> 
> ```
>  %files
>  %dir %{gem_instdir}
> -%exclude %{gem_instdir}/.gitignore
> +%exclude %{gem_instdir}/.*
>  %license %{gem_instdir}/LICENSE
>  %{gem_libdir}
>  %exclude %{gem_cache}
> @@ -64,8 +62,6 @@ popd
>  
>  %files doc
>  %doc %{gem_docdir}
> -%doc %{gem_instdir}/.rdoc_options
> -%exclude %{gem_instdir}/.rspec
>  %doc %{gem_instdir}/CONTRIBUTING.md
>  %{gem_instdir}/Gemfile
>  %doc %{gem_instdir}/README.md
> ```

Spec file and srpm updated with recommended review changes.

I executed fedora-review.


```
$ fedora-review -b 1779404
```

Then,

* License check: ok
* rpmlint check: ok
* Installing built binary RPMs in mock environment: ok

```
$ mock -i rubygem-hrx-1.0.0-1.fc32.noarch.rpm rubygem-hrx-doc-1.0.0-1.fc32.noarch.rpm
```

* Running the installed RPM in mock environment: ok

```
<mock-chroot> sh-5.0# gem list | grep hrx
hrx (1.0.0)

<mock-chroot> sh-5.0# irb
irb(main):001:0> require 'hrx'
=> true
```

* Scratch build:

```
$ koji build --scratch --nowait rawhide rubygem-hrx-1.0.0-1.fc32.src.rpm
https://koji.fedoraproject.org/koji/taskinfo?taskID=39439333
```

Package is APPROVED.

Thank you for the help and reviewing.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-hrx

FEDORA-2019-884a24c994 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-884a24c994

FEDORA-2019-126950287b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-126950287b

rubygem-hrx-1.0.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-126950287b

rubygem-hrx-1.0.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-884a24c994

rubygem-hrx-1.0.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

rubygem-hrx-1.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.