Bug 1781251 - Unbundle flamegraph from perl-Devel-NYTProf
Summary: Unbundle flamegraph from perl-Devel-NYTProf
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Devel-NYTProf
Version: rawhide
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-09 16:06 UTC by Edgar Hoch
Modified: 2019-12-19 02:14 UTC (History)
4 users (show)

Fixed In Version: perl-Devel-NYTProf-6.06-7.fc32 perl-Devel-NYTProf-6.06-7.fc31 perl-Devel-NYTProf-6.06-5.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-19 01:22:55 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Edgar Hoch 2019-12-09 16:06:05 UTC
Description of problem:

/usr/bin/flamegraph.pl is used by package perl-Devel-NYTProf for many years. flamegraph is a newer package - why uses it the same name for the binary excecutable as an existing package? It should use another name, which is not used by other packages. Both packages should be installable at the same time, because they did different things, but currently they conflict with each other.

Version-Release number of selected component (if applicable):
flamegraph-1.0-3.20191024.1a0dc69.fc31.noarch

How reproducible:
Always


Steps to Reproduce:
1. dnf install flamegraph perl-Devel-NYTProf

Actual results:
Error: Transaction test error:
  file /usr/bin/flamegraph.pl from install of flamegraph-1.0-3.20191024.1a0dc69.fc31.noarch conflicts with file from package perl-Devel-NYTProf-6.06-6.fc31.x86_64

Expected results:
No error, both packages should be installed.

Comment 1 Jerry James 2019-12-09 17:55:23 UTC
Actually, they are not different.  The flamegraph.pl in perl-Devel-NYTProf is a bundled copy of Brendan Gregg's flamegraph, which is now shipped in Fedora in the flamegraph package.  The correct fix to this issue is to unbundle flamegraph from perl-Devel-NYTProf.  It looks like it should be easy.  Simply remove %{buildroot}%{_bindir}/flamegraph.pl in %install, and add "Requires: flamegraph" to the spec file.

The version in perl-Devel-NYTProf is a little older than the one in the flamegraph package.  I have looked at the differences.  The version in the flamegraph package has several bug fixes (mostly regarding Unicode characters and SVG images) that are not fixed in the version in perl-Devel-NYTProf.  There are a couple of backwards incompatible changes, but grep did not find any uses of them in perl-Devel-NYTProf, so I believe that unbundling is safe.

Comment 2 Fedora Update System 2019-12-10 09:31:37 UTC
FEDORA-2019-56270ed316 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-56270ed316

Comment 3 Fedora Update System 2019-12-10 09:31:38 UTC
FEDORA-2019-2e27860bbd has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e27860bbd

Comment 4 Fedora Update System 2019-12-11 01:04:15 UTC
perl-Devel-NYTProf-6.06-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-56270ed316

Comment 5 Fedora Update System 2019-12-11 01:41:37 UTC
perl-Devel-NYTProf-6.06-7.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e27860bbd

Comment 6 Fedora Update System 2019-12-19 01:22:55 UTC
perl-Devel-NYTProf-6.06-7.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-12-19 02:14:41 UTC
perl-Devel-NYTProf-6.06-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.