Bug 1782667 - Some fields are disabling to edit when use a template
Summary: Some fields are disabling to edit when use a template
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.4.0
Assignee: Tomas Jelinek
QA Contact: Nelly Credi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-12 05:22 UTC by Guohua Ouyang
Modified: 2020-02-07 11:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-07 11:50:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Guohua Ouyang 2019-12-12 05:22:56 UTC
Description of problem:
Some fields {source, OS, Flavor, WorkloadProfile} are disabling editing when a template is in use, is it intending to do so? It seems not necessary because it's less flexibility.

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2019-12-04-054458

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Matt 2019-12-12 13:30:23 UTC
I would say this is expected behaviour but we could do a better job notifying the user that they can not edit details of a VM from a template. We can provided updated designs to cover this.

Comment 2 Tomas Jelinek 2019-12-12 13:32:11 UTC
OK, moving to 4.4 to see if we can enhance the UX

Comment 3 Ido Rosenzwig 2019-12-30 09:33:44 UTC
IMO, this is not an expected behavior in a user perspective.
One should be able to modify the fields that were populated by choosing a template.
We can further discuss how the UX would behave when a user modifies one field or more - what happens to the template name in the dropdown list? and other stuff.

Moreover, does a template wizard needs to have ALL the fields required like the VM wizard? why a template can't be created without fields that are 'required' (like workload profile: Desktop/Server) and when using it to create a VM the user will fill the missing 'required' fields and other properties if needed.

Another thing to think about is:  What happen when a template doesn't have certain labels like OS and workload-profile? - they are disabled, which leaves the user with a deadlock - these fields are required, they are not populated with any value and they cannot be changed (since they are disabled) - the user can't create the VM. :(

In conclusion, having the fields disabled when using a template is wrong, buggy and confusing for the user.

Comment 4 Tomas Jelinek 2020-02-07 11:50:24 UTC
There is a larger effort to redesign the templates. Lets move the discussion about how to do it properly there: https://issues.redhat.com/browse/CNV-3673


Note You need to log in before you can comment on or make changes to this bug.