Bug 1790040 - Desktop file is missing the Icon field
Summary: Desktop file is missing the Icon field
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: elisa-player
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-11 13:59 UTC by Matías Zúñiga
Modified: 2020-01-20 22:48 UTC (History)
1 user (show)

Fixed In Version: elisa-player-19.12.1-1.fc30 elisa-player-19.12.1-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-20 03:19:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Matías Zúñiga 2020-01-11 13:59:13 UTC
Description of problem: The .desktop file is missing the Icon field, and so Elisa is listed with a generic-program icon


Version-Release number of selected component (if applicable): 19.12.0-2.fc31


How reproducible: -


Steps to Reproduce:
1. Install elisa-player
2. Look for Elisa in the application drawer
3.

Actual results:
Elisa is listed without its icon.

Expected results:
Elisa is listed with its icon.

Additional info:
The .spec includes a sed command, modifying the .desktop file
   > sed -i '31d' org.kde.elisa.desktop

The .desktop file changes every release, so 'line 31' is not always the same field.

In the case of the 19.12.0 release, 'line 31' is the Icon field, and so it gets removed.

The .spec file shouldn't include a sed command that removes a line chosen by its line number.

Comment 1 Robert-André Mauchin 🐧 2020-01-11 14:38:48 UTC
Hi, thank you for your report. That line is a leftover foran older release and indeed shouldn't be there. I will push a fix along with the latest version 19.12.1.

Comment 2 Fedora Update System 2020-01-12 01:24:30 UTC
elisa-player-19.12.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e817b66368

Comment 3 Fedora Update System 2020-01-12 02:08:13 UTC
elisa-player-19.12.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f66ff0a7fd

Comment 4 Fedora Update System 2020-01-20 03:19:21 UTC
elisa-player-19.12.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2020-01-20 22:48:19 UTC
elisa-player-19.12.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.