Description of problem: denyhosts won't build under mock for fc5/devel due to unpackaged files. End of the build.log from mock: Processing files: denyhosts-1.1.4-2.fc5 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.70008 + umask 022 + cd /builddir/build/BUILD + cd DenyHosts-1.1.4 + DOCDIR=/var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild/usr/share/doc/denyhosts-1.1.4 + export DOCDIR + rm -rf /var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild/usr/share/doc/denyhosts-1.1.4 + /bin/mkdir -p /var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild/usr/share/doc/denyhosts-1.1.4 + cp -pr CHANGELOG.txt denyhosts.cfg-dist LICENSE.txt /var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild/usr/share/doc/denyhosts-1.1.4 + cp -pr README.fedora README.txt setup.py /var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild/usr/share/doc/denyhosts-1.1.4 + exit 0 Provides: config(denyhosts) = 1.1.4-2.fc5 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /bin/sh Requires(preun): /bin/sh Requires: /bin/bash /usr/bin/env /usr/bin/python config(denyhosts) = 1.1.4-2.fc5 openssh-server python(abi) = 2.4 Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/denyhosts-1.1.4-2.fc5-root-mockbuild error: Installed (but unpackaged) file(s) found: /usr/bin/denyhosts.pyc /usr/bin/denyhosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/__init__.pyo /usr/lib/python2.4/site-packages/DenyHosts/allowedhosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/constants.pyo /usr/lib/python2.4/site-packages/DenyHosts/counter.pyo /usr/lib/python2.4/site-packages/DenyHosts/daemon.pyo /usr/lib/python2.4/site-packages/DenyHosts/deny_hosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/denyfileutil.pyo /usr/lib/python2.4/site-packages/DenyHosts/filetracker.pyo /usr/lib/python2.4/site-packages/DenyHosts/lockfile.pyo /usr/lib/python2.4/site-packages/DenyHosts/loginattempt.pyo /usr/lib/python2.4/site-packages/DenyHosts/old-daemon.pyo /usr/lib/python2.4/site-packages/DenyHosts/plugin.pyo /usr/lib/python2.4/site-packages/DenyHosts/prefs.pyo /usr/lib/python2.4/site-packages/DenyHosts/python_version.pyo /usr/lib/python2.4/site-packages/DenyHosts/regex.pyo /usr/lib/python2.4/site-packages/DenyHosts/report.pyo /usr/lib/python2.4/site-packages/DenyHosts/util.pyo /usr/lib/python2.4/site-packages/DenyHosts/version.pyo RPM build errors: Installed (but unpackaged) file(s) found: /usr/bin/denyhosts.pyc /usr/bin/denyhosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/__init__.pyo /usr/lib/python2.4/site-packages/DenyHosts/allowedhosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/constants.pyo /usr/lib/python2.4/site-packages/DenyHosts/counter.pyo /usr/lib/python2.4/site-packages/DenyHosts/daemon.pyo /usr/lib/python2.4/site-packages/DenyHosts/deny_hosts.pyo /usr/lib/python2.4/site-packages/DenyHosts/denyfileutil.pyo /usr/lib/python2.4/site-packages/DenyHosts/filetracker.pyo /usr/lib/python2.4/site-packages/DenyHosts/lockfile.pyo /usr/lib/python2.4/site-packages/DenyHosts/loginattempt.pyo /usr/lib/python2.4/site-packages/DenyHosts/old-daemon.pyo /usr/lib/python2.4/site-packages/DenyHosts/plugin.pyo /usr/lib/python2.4/site-packages/DenyHosts/prefs.pyo /usr/lib/python2.4/site-packages/DenyHosts/python_version.pyo /usr/lib/python2.4/site-packages/DenyHosts/regex.pyo /usr/lib/python2.4/site-packages/DenyHosts/report.pyo /usr/lib/python2.4/site-packages/DenyHosts/util.pyo /usr/lib/python2.4/site-packages/DenyHosts/version.pyo Full build.log on request.
So, what on earth are .pyc and .pyo files? (Sorry, I don't speak much Python and find its install process hilariously bad.) Obviously they're not required, and my systems don't have this problem even though I always build with %_unpackaged_files_terminate_build and %_missing_doc_files_terminate_build. Oh, well, I'll rev the spec to delete these files.
Updates pushed and built successfully on the devel branch. I still have no idea what caused this. Perhaps the python update on the 24th? Older releases don't seem to have created those files.
See: http://fedoraproject.org/wiki/Packaging/Python You didn't see these likely because you didn't build as root, but mock does. They suggest in the above url that you package the .pyc files, and set things to not build the .pyo files and %ghost them in the files section so they are removed on uninstall.
Interesting. I've reworked a bit of the spec to better meet those guidelines and have pushed a build. Feel free to check over the current specfile and see if I've done anything wrong. This package was imported before we had the current rigorous review guidelines in place so it saw far less scrutiny than it would if it were submitted now.
Yeah, those changes look all good to me. I'm no python packaging guru, but I think those changes do the right thing. ;) Thanks for fixing it up.