Bug 181049 - fonts-chinese's postinstall has mistake(fonts-chinese-3.02-4.1)
Summary: fonts-chinese's postinstall has mistake(fonts-chinese-3.02-4.1)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: fonts-chinese
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Caius Chance
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-02-12 11:51 UTC by Miao ZhiCheng
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version: 3.02-7.fc6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-05-03 07:37:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
proposed modified .spec file (6.47 KB, text/plain)
2006-09-06 04:58 UTC, Caius Chance 		no flags Details
View All

Description Miao ZhiCheng 2006-02-12 11:51:07 UTC 
postinstall scriptlet (using /bin/sh):
{
        umask 133
        touch /usr/share/fonts/chinese/TrueType 2> /dev/null && {
                /usr/bin/ttmkfdir -d /usr/share/fonts/chinese/TrueType -o
/usr/share/fonts/chinese/TrueType/fonts.scale
            mkfontdir /usr/share/fonts/chinese/TrueType
                /usr/sbin/chkfontpath -q -a /usr/share/fonts/chinese/TrueType
        }

        touch /usr/share/fonts/chinese/misc 2> /dev/null && {
                /usr/bin/ttmkfdir -d /usr/share/fonts/chinese/misc -o
/usr/share/fonts/chinese/misc/fonts.scale
            mkfontdir /usr/share/fonts/chinese/TrueType
                /usr/sbin/chkfontpath -q -a /usr/share/fonts/chinese/misc
        }
        #Update fontconfig cache
        [  -x /usr/bin/fc-cache ] && /usr/bin/fc-cache 2> /dev/null
}


I think the second mkfontdir should be :
            mkfontdir /usr/share/fonts/chinese/misc
Comment 1 Caius Chance 2006-08-21 02:03:45 UTC 
Sounds resaonable.

Modified and in progress of testing.
Comment 2 Jens Petersen 2006-08-21 02:11:05 UTC 
I suggest rewriting the above as a for loop to avoid this kind of
potential problem repeating.
Comment 3 Caius Chance 2006-09-06 04:58:09 UTC 
Created attachment 135620 [details]
proposed modified .spec file

Modified. Proposed after feedback lines during install on test machine:

+ umask 133
+ for tmpfontdir in /usr/share/fonts/chinese/TrueType
/usr/share/fonts/chinese/misc
+ touch /usr/share/fonts/chinese/TrueType
+ /usr/bin/ttmkfdir -d /usr/share/fonts/chinese/TrueType -o
/usr/share/fonts/chinese/TrueType/fonts.scale
+ mkfontdir /usr/share/fonts/chinese/TrueType
+ /usr/sbin/chkfontpath -q -a /usr/share/fonts/chinese/TrueType
+ for tmpfontdir in /usr/share/fonts/chinese/TrueType
/usr/share/fonts/chinese/misc
+ touch /usr/share/fonts/chinese/misc
+ /usr/bin/ttmkfdir -d /usr/share/fonts/chinese/misc -o
/usr/share/fonts/chinese/misc/fonts.scale
+ mkfontdir /usr/share/fonts/chinese/misc
+ /usr/sbin/chkfontpath -q -a /usr/share/fonts/chinese/misc
+ '[' -x /usr/bin/fc-cache ']'
+ /usr/bin/fc-cache
Comment 4 Caius Chance 2006-09-06 06:29:28 UTC 
The following package has been built and pending for QC.

fonts-chinese-3.02-7.fc6

After QC passed, will backport to fc5.
Comment 5 Caius Chance 2007-05-03 07:37:27 UTC 
Fixed in fonts-chinese-3.02-7.fc6, built and pushed.
Note You need to log in before you can comment on or make changes to this bug.