Bug 1815736 - Does not compile with k8s.io/apimachinery 1.17.2
Summary: Does not compile with k8s.io/apimachinery 1.17.2
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: golang-github-containerd-cri
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-21 09:03 UTC by Olivier Lemasle
Modified: 2020-03-30 01:49 UTC (History)
2 users (show)

Fixed In Version: golang-github-containerd-cri-1.11.1-6.fc32 golang-github-containerd-cri-1.11.1-6.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-30 00:16:16 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Olivier Lemasle 2020-03-21 09:03:35 UTC 
Description of problem:

github.com/containerd/cri in version 1.11.1 depends on an old version of k8s.io/apimachinery (commit ed135c5b96450fd24e5e981c708114fbbd950697).

However, golang-k8s-apimachinery has been updated in Fedora repos to version 1.17.2, which breaks golang-github-containerd-cri-devel:

More specifically, 
github.com/containerd/cri uses k8s.io/apimachinery/pkg/util/net.ChooseBindAddress [1] which has been removed in k8s.io/apimachinery [2].

[1] https://github.com/containerd/cri/blob/v1.11.1/pkg/server/streaming.go#L39
[2] https://godoc.org/k8s.io/apimachinery/pkg/util/net


Version-Release number of selected component (if applicable): golang-github-containerd-cri-1.11.1-5
Comment 1 Olivier Lemasle 2020-03-21 09:10:25 UTC 
Proposed fix in PR https://src.fedoraproject.org/rpms/golang-github-containerd-cri/pull-request/1
Comment 2 Robert-André Mauchin 🐧 2020-03-21 16:27:28 UTC 
k8s is in the process of being updated but due to the lack of reviewers it is halted. I will look at your Merge Request.
Comment 3 Fedora Update System 2020-03-21 16:58:57 UTC 
FEDORA-2020-aacd201f87 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-aacd201f87
Comment 4 Olivier Lemasle 2020-03-21 18:36:19 UTC 
Thank you Robert-André; this was required to build package containerd.
Comment 5 Fedora Update System 2020-03-22 00:39:01 UTC 
golang-github-containerd-cri-1.11.1-6.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-289a6d0f61
Comment 6 Fedora Update System 2020-03-22 01:41:30 UTC 
golang-github-containerd-cri-1.11.1-6.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-aacd201f87
Comment 7 Fedora Update System 2020-03-30 00:16:16 UTC 
FEDORA-2020-aacd201f87 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Fedora Update System 2020-03-30 01:49:13 UTC 
FEDORA-2020-289a6d0f61 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.