Bug 1835314 - [OVN SCALE] Spurious and unnecessary echoes on JSON RPC connections
Summary: [OVN SCALE] Spurious and unnecessary echoes on JSON RPC connections
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Red Hat Enterprise Linux Fast Datapath
Classification: Red Hat
Component: openvswitch
Version: RHEL 8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: OVN Team
QA Contact: qding
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-13 15:16 UTC by Anton Ivanov
Modified: 2022-10-05 18:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-05 18:08:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FD-653 0 None None None 2022-02-22 05:50:43 UTC

Description Anton Ivanov 2020-05-13 15:16:29 UTC
The connection keep-alive probing is configured incorrectly on the server side (stream created as a result of an accept() call).

The code to set or unset the probe interval relies on stream_or_pstream_needs_probes() which in turn calls stream_lookup_class().

That function is broken to start off with - it returns a mix of boolean and integer. 

It also fails to match streams created out of accept which have names like unix#9. 

That results in them erroneously being flagged as in need of keep-alives even if they do not need to.

If there is an existing stream (as is always the case when coming out of accept) it is possible to access the value of the boolean needs_probes directly from the stream class structure, there is no need to jump through hoops to try to figure it out from the name.

Comment 1 Anton Ivanov 2020-05-29 13:06:24 UTC
I have a fix for this, ETA for upstream submission - before Monday 1st of June 17:00 BST.

A.

Comment 2 Anton Ivanov 2020-06-02 07:41:46 UTC
Patch upstream, fix on top of master can be picked up from here: https://github.com/kot-begemot-uk/ovs/commit/0e533eeacaea3e2f8d662940a250e551dd515f13

Comment 4 Mark Michelson 2022-10-05 18:08:18 UTC
Closing this issue since a newer one has been opened with the intent of getting the same functionality implemented, but via a different means (https://bugzilla.redhat.com/show_bug.cgi?id=2100497)


Note You need to log in before you can comment on or make changes to this bug.