Bug 1855927 - HTML templates and fixtures not installed by upstream install scripts, package has to hack them in
Summary: HTML templates and fixtures not installed by upstream install scripts, packag...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: zezere
Version: 36
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-11 01:12 UTC by Adam Williamson
Modified: 2023-05-25 19:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-25 19:39:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2020-07-11 01:12:36 UTC
The zezere source contains several templates:

https://github.com/fedora-iot/zezere/tree/master/zezere/templates

but none of them appears to be included in the RPM package. I'm trying to get a working deployment from the package, but when I run the server and try to browse the web interface, I get a traceback on the server end:

Internal Server Error: /accounts/login/
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/lib/python3.9/site-packages/django/core/handlers/base.py", line 145, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/lib/python3.9/site-packages/django/core/handlers/base.py", line 143, in _get_response
    response = response.render()
  File "/usr/lib/python3.9/site-packages/django/template/response.py", line 105, in render
    self.content = self.rendered_content
  File "/usr/lib/python3.9/site-packages/django/template/response.py", line 81, in rendered_content
    template = self.resolve_template(self.template_name)
  File "/usr/lib/python3.9/site-packages/django/template/response.py", line 63, in resolve_template
    return select_template(template, using=self.using)
  File "/usr/lib/python3.9/site-packages/django/template/loader.py", line 47, in select_template
    raise TemplateDoesNotExist(', '.join(template_name_list), chain=chain)
django.template.exceptions.TemplateDoesNotExist: registration/login.html
"GET /accounts/login/?next=/portal/ HTTP/1.1" 500 145

apparently because the template files are missing.

Comment 1 Adam Williamson 2020-07-13 23:31:48 UTC
So this is kinda odd. The templates are listed in MANIFEST.in (slightly wrongly - the trailing * is wrong when using graft - but this doesn't seem to be the problem). setup.py has include_package_data=True . The template files are included in the tarball. But somehow, the 'build' and 'install' steps don't include the template files. I'm really not sure why not.

Comment 2 Adam Williamson 2020-07-14 00:34:21 UTC
I fixed this in Rawhide and F32, with a kinda hacky bodge job in the spec. But leaving the bug open at least temporarily in case anyone might be able to figure out why build/install don't include the template files.

Comment 3 Peter Robinson 2020-07-14 08:10:30 UTC
We had put this in our work queue to deal with properly.

Comment 4 Fedora Update System 2020-07-14 14:59:26 UTC
FEDORA-2020-bc91fddb22 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc91fddb22

Comment 5 Adam Williamson 2020-07-14 15:01:50 UTC
Gah, I didn't mean to have the update close the bug. Changed.

Comment 6 Fedora Update System 2020-07-15 02:01:05 UTC
FEDORA-2020-bc91fddb22 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-bc91fddb22`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc91fddb22

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Adam Williamson 2020-07-15 02:09:37 UTC
Grr, seems like editing an update not to close bugs doesn't work :(

Comment 8 Adam Williamson 2020-07-21 21:49:16 UTC
Along the same lines, the package doesn't include the fixtures. Which it probably should, because you need them for a functional deployment. They contain the default run requests.

Comment 9 Fedora Update System 2020-07-21 22:27:15 UTC
FEDORA-2020-bc91fddb22 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc91fddb22

Comment 10 Adam Williamson 2020-07-22 00:46:42 UTC
so in -5 I hacked the fixtures into the package the same dumb way I did the templates.

Comment 11 Fedora Update System 2020-07-22 01:16:14 UTC
FEDORA-2020-bc91fddb22 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-bc91fddb22`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc91fddb22

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Peter Robinson 2020-07-22 07:38:20 UTC
We'll get a new release done upstream with these bits bundled up shortly

Comment 13 Fedora Update System 2020-07-30 18:55:06 UTC
FEDORA-2020-bc91fddb22 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Ben Cotton 2020-08-11 15:21:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 15 Ben Cotton 2021-11-04 17:36:51 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 16 Adam Williamson 2021-11-05 23:44:13 UTC
This is, uh, still valid all the way up to Rawhide, I think. My dumb hacks are still in the spec and the package is still at 0.5.

A 0.5.1 showed up upstream, but was never packaged downstream. I don't know if it fixed this.

Comment 17 Ben Cotton 2022-02-08 21:31:36 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 18 Ben Cotton 2023-04-25 18:28:46 UTC
This message is a reminder that Fedora Linux 36 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '36'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 36 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 19 Adam Williamson 2023-04-28 00:09:22 UTC
Looks like 0.5.2 fixed this. That went to F37 and F38, so we can let this die with F36.

Comment 20 Ludek Smid 2023-05-25 19:39:41 UTC
Fedora Linux 36 entered end-of-life (EOL) status on 2023-05-16.

Fedora Linux 36 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.