Bug 1856310 - Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks
Summary: Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupy...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1856311 1856313
TreeView+ depends on / blocked
 
Reported: 2020-07-13 11:21 UTC by Lumír Balhar
Modified: 2020-07-20 04:22 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-16 05:56:13 UTC
Type: ---
Embargoed:
mhroncok: fedora-review+


Attachments (Terms of Use)

Description Lumír Balhar 2020-07-13 11:21:22 UTC
Spec URL: https://lbalhar.fedorapeople.org/python-widgetsnbextension.spec
SRPM URL: https://lbalhar.fedorapeople.org/python-widgetsnbextension-3.5.1-1.fc32.src.rpm
Description: Interactive HTML widgets for Jupyter notebooks.
Fedora Account System Username: lbalhar

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47113028

There is a conflict between this package and sagemath-jupyter (sagemath) which provides this inside its subpackage so I'll open a bug to remove it from there.

Comment 1 Miro Hrončok 2020-07-13 11:44:32 UTC
Spec sanity:

This is useless on rawhide:

  %{?python_provide:%python_provide python3-%{pypi_name}}

This is probably useless as well:

  # Remove bundled egg-info
  rm -rf %{pypi_name}.egg-info

Th rest looks reasonable from the fist glance.

Comment 2 Miro Hrončok 2020-07-13 11:46:30 UTC
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info

Consider adding trailing slashes to ensure those are directories.

Comment 3 Miro Hrončok 2020-07-13 14:45:18 UTC
Preliminary review:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 3-clause "New" or "Revised" License", "Unknown or
     generated", "Expat License". 16 files have unknown license.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/jupyter/nbconfig,
     /usr/share/jupyter/nbextensions, /usr/share/jupyter,
     /etc/jupyter/nbconfig/notebook.d, /etc/jupyter
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/jupyter/nbextensions/jupyter-js-widgets(sagemath-jupyter)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python3-widgetsnbextension-3.5.1-1.fc33.noarch.rpm
          python-widgetsnbextension-3.5.1-1.fc33.src.rpm
python3-widgetsnbextension.noarch: W: spelling-error Summary(en_US) IPython -> I Python, Python, Diphthong
python3-widgetsnbextension.noarch: W: no-documentation
python-widgetsnbextension.src: W: spelling-error Summary(en_US) IPython -> I Python, Python, Diphthong
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
(none): E: no installed packages by name python3-widgetsnbextension



Source checksums
----------------
https://files.pythonhosted.org/packages/source/w/widgetsnbextension/widgetsnbextension-3.5.1.tar.gz :
  CHECKSUM(SHA256) this package     : 079f87d87270bce047512400efd70238820751a11d2d8cb137a5a5bdbaf255c7
  CHECKSUM(SHA256) upstream package : 079f87d87270bce047512400efd70238820751a11d2d8cb137a5a5bdbaf255c7


Requires
--------
python3-widgetsnbextension (rpmlib, GLIBC filtered):
    config(python3-widgetsnbextension)
    python(abi)
    python3.9dist(notebook)
    python3dist(notebook)



Provides
--------
python3-widgetsnbextension:
    config(python3-widgetsnbextension)
    python-widgetsnbextension
    python3-widgetsnbextension
    python3.9-widgetsnbextension
    python3.9dist(widgetsnbextension)
    python3dist(widgetsnbextension)



Diff spec file in url and in SRPM
---------------------------------
--- /home/churchyard/rpmbuild/FedoraReview/1856310-python-widgetsnbextension/srpm/python-widgetsnbextension.spec	2020-07-13 13:48:03.039019752 +0200
+++ /home/churchyard/rpmbuild/FedoraReview/1856310-python-widgetsnbextension/srpm-unpacked/python-widgetsnbextension.spec	2020-07-13 13:04:40.000000000 +0200
@@ -5,5 +5,5 @@
 Version:        3.5.1
 Release:        1%{?dist}
-Summary:        Interactive HTML widgets for Jupyter notebooks
+Summary:        IPython HTML widgets for Jupyter
 
 License:        BSD

Comment 4 Lumír Balhar 2020-07-13 19:15:01 UTC
(In reply to Miro Hrončok from comment #3)
> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by:
>      /usr/share/jupyter/nbextensions/jupyter-js-widgets(sagemath-jupyter)
> …
> [!]: Package does not generate any conflict.

I am waiting for a reply in https://bugzilla.redhat.com/show_bug.cgi?id=1856311

> [!]: %check is present and all tests pass.

There are no tests upstream.

> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

I'll fix that during the initial import.

Comment 5 Lumír Balhar 2020-07-14 04:16:31 UTC
(In reply to Miro Hrončok from comment #1)
> Spec sanity:
> 
> This is useless on rawhide:
> 
>   %{?python_provide:%python_provide python3-%{pypi_name}}
> 
> This is probably useless as well:
> 
>   # Remove bundled egg-info
>   rm -rf %{pypi_name}.egg-info
> 
> Th rest looks reasonable from the fist glance.

Both removed.

> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

Fixed.

Comment 6 Miro Hrončok 2020-07-14 16:58:48 UTC
> Package does not generate any conflict. I am waiting for a reply in https://bugzilla.redhat.com/show_bug.cgi?id=1856311

Could you add this in the meantime? It will need to stay anyway:

  # sagemath included the files of this package
  # https://bugzilla.redhat.com/show_bug.cgi?id=1856311
  Conflicts: sagemath < 9.1-2

With that, I think it can be approved.

Comment 7 Lumír Balhar 2020-07-15 04:59:22 UTC
(In reply to Miro Hrončok from comment #6)
> > Package does not generate any conflict. I am waiting for a reply in https://bugzilla.redhat.com/show_bug.cgi?id=1856311
> 
> Could you add this in the meantime? It will need to stay anyway:
> 
>   # sagemath included the files of this package
>   # https://bugzilla.redhat.com/show_bug.cgi?id=1856311
>   Conflicts: sagemath < 9.1-2
> 
> With that, I think it can be approved.

Good idea. I've just changed it to sagemath-jupyter. Files updated.

Comment 8 Miro Hrončok 2020-07-15 07:30:31 UTC
> I've just changed it to sagemath-jupyter.

Right, good catch!


One more thing, the package need to runtime require python-jupyter-filesystem, not buildrequire. Sorry for not noticing sooner.

Comment 9 Lumír Balhar 2020-07-15 07:36:01 UTC
> One more thing, the package need to runtime require
> python-jupyter-filesystem, not buildrequire. Sorry for not noticing sooner.

Updated. No problem. I just think that it needs it for both build/run otherwise fedora-review complains about folders created but not owned by this package.

Comment 10 Miro Hrončok 2020-07-15 07:39:52 UTC
Package APPROVED.

Comment 11 Lumír Balhar 2020-07-15 08:52:18 UTC
Thank you!

Component request: https://pagure.io/releng/fedora-scm-requests/issue/27125

Comment 12 Gwyn Ciesla 2020-07-15 12:42:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-widgetsnbextension

Comment 13 Lumír Balhar 2020-07-16 05:56:13 UTC
In rawhide soon: https://bodhi.fedoraproject.org/updates/FEDORA-2020-236351a8f9

Comment 14 Miro Hrončok 2020-07-19 21:38:27 UTC
Could you add python-sig to the maintaier list?

Comment 15 Lumír Balhar 2020-07-20 04:22:13 UTC
(In reply to Miro Hrončok from comment #14)
> Could you add python-sig to the maintaier list?

Done.


Note You need to log in before you can comment on or make changes to this bug.