Bug 185776 - Review Request: gitweb
Review Request: gitweb
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2006-03-17 16:16 EST by bkyoung
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-09-06 15:36:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Spec for for gitweb. (1.97 KB, text/plain)
2006-03-17 16:18 EST, bkyoung
no flags Details
Object location adjustments. (1.37 KB, patch)
2006-03-17 16:19 EST, bkyoung
no flags Details | Diff
A quick installation test/check; Additional info. (2.06 KB, text/plain)
2006-03-17 16:19 EST, bkyoung
no flags Details
Spec for gitweb. Fixed #5. (2.50 KB, text/plain)
2006-03-18 12:56 EST, bkyoung
no flags Details
Spec file - Changed directory to gitweb. (2.61 KB, text/plain)
2006-03-21 22:02 EST, bkyoung
no flags Details
Object location adjustments. (1.37 KB, text/plain)
2006-03-21 22:02 EST, bkyoung
no flags Details
A quick installation test/check. Additional info. (2.06 KB, text/plain)
2006-03-21 22:04 EST, bkyoung
no flags Details

  None (edit)
Description bkyoung 2006-03-17 16:16:55 EST
Spec Name or Url: Attached
SRPM Name or Url: Build separately
Description: A CGI based web interface for git projects published to a git repository.

See notes at end of attached gitweb-check for obtaining source tarball.

Attached:
gitweb.spec
gitweb-2.6.4-gitweb.cgi.patch
gitweb-check

BEGIN OUTPUT rpmlint
W: gitweb dangerous-command-in-%post chown
W: gitweb dangerous-command-in-%postun groupdel
END OUTPUT rpmlint
Comment 1 bkyoung 2006-03-17 16:18:17 EST
Created attachment 126287 [details]
Spec for for gitweb.
Comment 2 bkyoung 2006-03-17 16:19:08 EST
Created attachment 126288 [details]
Object location adjustments.
Comment 3 bkyoung 2006-03-17 16:19:51 EST
Created attachment 126289 [details]
A quick installation test/check; Additional info.
Comment 4 bkyoung 2006-03-17 19:15:48 EST
Comment on attachment 126287 [details]
Spec for for gitweb.

>%postun
># Remove group %{_gitweb_group}
>groupdel %{_gitweb_group}
>

%postun
if test $1 -eq 0; then
# Remove group %{_gitweb_group} for erase
	groupdel %{_gitweb_group} || true > /dev/null 2>&1
fi

The _gitweb_group should remain after an upgrade, but be removed after an
erase!
Comment 5 Paul Howarth 2006-03-18 04:22:22 EST
(In reply to comment #4)
> (From update of attachment 126287 [details] [edit])
> >%postun
> ># Remove group %{_gitweb_group}
> >groupdel %{_gitweb_group}
> >
> 
> %postun
> if test $1 -eq 0; then
> # Remove group %{_gitweb_group} for erase
> 	groupdel %{_gitweb_group} || true > /dev/null 2>&1
> fi
> 
> The _gitweb_group should remain after an upgrade, but be removed after an
> erase!

It should only be removed if you can be sure that no files belonging to this
group will remain on the system after the package has been removed. Otherwise,
the group should not be removed at all.
Comment 6 bkyoung 2006-03-18 12:56:45 EST
Created attachment 126309 [details]
Spec for gitweb. Fixed #5.
Comment 7 bkyoung 2006-03-21 22:02:13 EST
Created attachment 126451 [details]
Spec file - Changed directory to gitweb.
Comment 8 bkyoung 2006-03-21 22:02:59 EST
Created attachment 126452 [details]
Object location adjustments.
Comment 9 bkyoung 2006-03-21 22:04:02 EST
Created attachment 126453 [details]
A quick installation test/check. Additional info.
Comment 10 Patrice Dumas 2006-07-23 17:26:37 EDT
Could you please add the url to the spec file and the srpm in a 
bugzilla comment?
Comment 11 Jason Tibbitts 2006-08-30 02:12:20 EDT
I will close this bug in one week if there is no response.

Note You need to log in before you can comment on or make changes to this bug.