When we introduced python2-numpy bz1734445, there was this brief discussion: Me: > Provides: numpy = %{epoch}:%{version}-%{release} > Provides: numpy%{?_isa} = %{epoch}:%{version}-%{release} > Provides: f2py = %{epoch}:%{version}-%{release} > Provides: numpy-f2py = %{epoch}:%{version}-%{release} > > I believe those should now be in the Python 3 package: https://fedoraproject.org/wiki/Changes/Python_means_Python3 Gwyn: > I think the numpy Provides should follow python2-numpy, as the python3- naming is compliant and that isn't. It also minimizes breakage for users if dependent packages have bad Requires on numpy. Me: BTW I don't agree but won't block this review on that. Would you re-consider moving the provides to python3-numpy for Fedora 33+? python2-numpy as a separate package existed now for 2 releases. There are packages that BuildRequire numpy: $ repoquery --repo=rawhide{,-source} --whatrequires numpy --exact kiss-fft-0:1.3.0-10.fc32.src qcint-0:3.0.20-2.fc33.src quantum-espresso-0:6.5-1.fc33.src I would fix them in the process.
I'm not categorically opposed, but I'm curious what we gain by moving them. What's the advantage of this over simply fixing the 3 packages that use the old-style non-compliant names and eliminating these provides? If there is one I can certainly do this, I'm just unsure of the benefit.
The benefit is for the end users who might do: dnf install numpy Currently, they get the numpy for an upstream unsupported Python version, possibly also pulling the python2.7 package in.
Fair enough. Should I do this immediately or do you want to coordinate?
I'll submit PRs to kiss-fft, qcint, quantum-espresso. I can also make the necessary changes in numpy and python2-numpy myself, directly or via a Pull Request, but feel free to do it yourself, if you prefer that.
I've got them staged, so I'll just do it now then.
There is already https://src.fedoraproject.org/rpms/qcint/pull-request/1 There is already https://src.fedoraproject.org/rpms/quantum-espresso/c/95717edc4f6260b7bae675111f18d3b9d6e0b91d?branch=master I've opened https://src.fedoraproject.org/rpms/kiss-fft/pull-request/1
https://src.fedoraproject.org/rpms/numpy/c/0a40ade4bb52f0a9ca3d4bc1436d02eb93ac318b?branch=master I'm not sure about the obsoletes. The package will replace the older python2-numpy package which is probably not desired.
Scratch that, the older python2-numpy package has higher version. Sorry for writing without thinking.
I wish I had a dollar for every time I've done that. :)
Builds complete.
Thank you, Gwyn!