Bug 1862978 - After upgrade to Fedora 32, bip stopped accepting logins
Summary: After upgrade to Fedora 32, bip stopped accepting logins
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: bip
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Williamson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-03 11:48 UTC by Jan Pazdziora
Modified: 2020-09-01 19:30 UTC (History)
3 users (show)

Fixed In Version: bip-0.9.0-0.7.20181225gitc9cc64f.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-01 19:30:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora 2020-08-03 11:48:12 UTC
Description of problem:

After upgrade to Fedora 32, bip stopped accepting logins.

Version-Release number of selected component (if applicable):

bip-0.9.0-0.6.20181225gitc9cc64f.fc32.x86_64

How reproducible:

Deterministic.

Steps to Reproduce:
1. Have working setup of bip + hexchat on Fedora 31 and upgrade to Fedora 32.
2. Start the bip service and start hexchat which connects to it.

Actual results:

bip[37689]: 03-08-2020 13:31:26 ERROR: [irc.freenode.net] Invalid credentials (user: adelton:)

Expected results:

No invalid credentials, things working as in Fedora 31.

Additional info:

Checking the code which says

src/irc.c:              mylog(LOG_ERROR, "[%s] Invalid credentials (user: %s)",

the trailing colon after the username was suspicious.

I then looked around in koji and found build

  https://koji.fedoraproject.org/koji/buildinfo?buildID=1497629

which says in changelog

* Thu Apr 23 2020 Tom Hughes <tom> - 0.9.0-0.7.20181225gitc9cc64f
- Fix patch to correctly terminate strings

and the 0001-Fix-stringop-truncation-error-thanks-DJ-Delorie.patch is different.

I've installed that version and now things work fine.

So perhaps all that is needed is to push that build via bodhi to Fedora 32 updates?

Comment 1 Jan Pazdziora 2020-08-24 09:36:02 UTC
Hello, any chance of creating errata in Bodhi for the build so that the fix gets to Fedora 32?

Comment 2 Adam Williamson 2020-08-24 15:03:58 UTC
oh, sorry, I didn't see this report, for some reason. Sure.

Comment 3 Fedora Update System 2020-08-24 15:06:22 UTC
FEDORA-2020-2e0a951837 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2e0a951837

Comment 4 Fedora Update System 2020-08-25 01:59:58 UTC
FEDORA-2020-2e0a951837 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-2e0a951837`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2e0a951837

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2020-09-01 19:30:23 UTC
FEDORA-2020-2e0a951837 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.