Description of problem: The agent is called wrapped by a timeout utility. If it fails it would return a "dhclient existed with non-zero exit code 124" error message. Steps to Reproduce: 1. Some DHCP server failure Actual results: dhclient existed with non-zero exit code 124: Internet Systems Consortium DHCP Client 4.3.6\nCopyright 2004-2017 Internet Systems Consortium.\nAll rights reserved.\nFor info, please visit https://www.isc.org/software/dhcp/\n\nListening on LPF/ingress/00:1a:4a:c4:dd:ec\nSending on LPF/ingress/00:1a:4a:c4:dd:ec\nSending on Socket/fallback\nNot enough data in /etc/machine-id\nCreated duid \"\\000\\001\\000\\001'\\0067A\\000\\032J\\304\\335\\354\".\nDHCPDISCOVER on ingress to 255.255.255.255 port 67 interval 8 (xid=0x477a714e)\nDHCPREQUEST on ingress to 255.255.255.255 port 67 (xid=0x477a714e)\nDHCPOFFER from 10.10.10.5\n Expected results: dhclient failed on timeout of %d seconds Additional info: - Should fix "existed" to "exited". - Extend timeout for more than 5 seconds.
PR https://github.com/openshift/assisted-installer-agent/pull/57
just a test
Verified on OCP-Metal-v1.0.11.1 Error message: Nov 16 16:58:30 master-0-1 dhcp_lease_allo[4880]: time="16-11-2020 16:58:30" level=error msg="Failed to lease a vip" file="dhcp_lease_allocate.go:98" error="dhclient was timed out after 28 seconds" ip= mac="00:1a:4a:f0:44:2b" masterDevice=ens3 name=api