This service will be undergoing maintenance at 00:00 UTC, 2016-09-28. It is expected to last about 1 hours
Bug 190361 - Regression: GUI no longers warns of an invalid cluster.conf file
Regression: GUI no longers warns of an invalid cluster.conf file
Status: CLOSED ERRATA
Product: Red Hat Cluster Suite
Classification: Red Hat
Component: redhat-config-cluster (Show other bugs)
4
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jim Parsons
Cluster QE
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-01 12:27 EDT by Corey Marthaler
Modified: 2009-04-16 16:11 EDT (History)
2 users (show)

See Also:
Fixed In Version: RHBA-2006-0572
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-08-10 17:11:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Corey Marthaler 2006-05-01 12:27:01 EDT
Description of problem:
The GUI used to warn the user when there was invalid XML or an missing section
in the config file, now it just crashes:


Invalid tag was added to the config:
[root@taft-02 ~]# system-config-cluster
Traceback (most recent call last):
  File "/usr/sbin/system-config-cluster", line 553, in ?
    runFullGUI()
  File "/usr/sbin/system-config-cluster", line 535, in runFullGUI
    baseapp = basecluster(glade_xml, app)
  File "/usr/sbin/system-config-cluster", line 124, in __init__
    self.model_builder = ModelBuilder(1, CLUSTER_CONF_PATH)
  File "/usr/share/system-config-cluster/ModelBuilder.py", line 127, in __init__
    self.parent = minidom.parse(self.filename)
  File "/usr/lib64/python2.3/xml/dom/minidom.py", line 1919, in parse
    return expatbuilder.parse(file)
  File "/usr/lib64/python2.3/xml/dom/expatbuilder.py", line 924, in parse
    result = builder.parseFile(fp)
  File "/usr/lib64/python2.3/xml/dom/expatbuilder.py", line 207, in parseFile
    parser.Parse(buffer, 0)
xml.parsers.expat.ExpatError: mismatched tag: line 49, column 2



Missing fence device declaration from config:
[root@taft-02 ~]# system-config-cluster
Traceback (most recent call last):
  File "/usr/sbin/system-config-cluster", line 553, in ?
    runFullGUI()
  File "/usr/sbin/system-config-cluster", line 535, in runFullGUI
    baseapp = basecluster(glade_xml, app)
  File "/usr/sbin/system-config-cluster", line 124, in __init__
    self.model_builder = ModelBuilder(1, CLUSTER_CONF_PATH)
  File "/usr/share/system-config-cluster/ModelBuilder.py", line 134, in __init__
    self.resolve_fence_instance_types()
  File "/usr/share/system-config-cluster/ModelBuilder.py", line 291, in
resolve_fence_instance_types
    child.setAgentType(agent_hash[child.getName()])
KeyError: u'qawti-01'


Version-Release number of selected component (if applicable):
system-config-cluster-1.0.25-1.0

How reproducible:
everytime
Comment 1 Corey Marthaler 2006-05-01 12:30:25 EDT
Here's a copy of the config:

[root@taft-02 ~]# cat /etc/cluster/cluster.conf
<?xml version="1.0"?>
<cluster config_version="4" name="TAFT_CLUSTER">
<sdfsd>
  <cman>
                </cman>
  <fence_daemon clean_start="0" post_fail_delay="30" post_join_delay="30"/>
  <clusternodes>
    <clusternode name="taft-01">
      <fence>
                                        <method name="1">
                                                <device name="qawti-01"
option="off" port="1"/>
                                                <device name="qawti-01"
option="off" port="5"/>
                                                <device name="qawti-01"
option="on" port="1"/>
                                                <device name="qawti-01"
option="on" port="5"/>
                                        </method>
                                </fence>
    </clusternode>
    <clusternode name="taft-02">
      <fence>
                                        <method name="1">
                                                <device name="qawti-01"
option="off" port="2"/>
                                                <device name="qawti-01"
option="off" port="6"/>
                                                <device name="qawti-01"
option="on" port="2"/>
                                                <device name="qawti-01"
option="on" port="6"/>
                                        </method>
                                </fence>
    </clusternode>
    <clusternode name="taft-03">
      <fence>
                                        <method name="1">
                                                <device name="qawti-01"
option="off" port="3"/>
                                                <device name="qawti-01"
option="off" port="7"/>
                                                <device name="qawti-01"
option="on" port="3"/>
                                                <device name="qawti-01"
option="on" port="7"/>
                                        </method>
                                </fence>
    </clusternode>
    <clusternode name="taft-04">
      <fence>
                                        <method name="1">
                                                <device name="qawti-01"
option="off" port="4"/>
                                                <device name="qawti-01"
option="off" port="8"/>
                                                <device name="qawti-01"
option="on" port="4"/>
                                                <device name="qawti-01"
option="on" port="8"/>
                                        </method>
                                </fence>
    </clusternode>
  </clusternodes>
</cluster>
Comment 2 Ryan McCabe 2006-05-13 23:05:04 EDT
i've updated the relaxng schema to support the features it was missing (samba
resource, rsa fence agent, rps10 fence agent, fsid). xmllint ought to validate
conf files with no errors now, but when it does encounter a file with errors,
its output is unhelpful. i didn't remove the immediate return from the function
that calls xmllint, but if it is removed, it will only complain about invalid
conf files.
Comment 6 Red Hat Bugzilla 2006-08-10 17:11:57 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2006-0572.html

Note You need to log in before you can comment on or make changes to this bug.