Bug 1913548 - [machines] Can not accept mouse input correctly in vm console tab unless Expand it [NEEDINFO]
Summary: [machines] Can not accept mouse input correctly in vm console tab unless Expa...
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: 8.9
Assignee: Simon Kobyda
QA Contact: Xianghua Chen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-07 04:17 UTC by Xianghua Chen
Modified: 2023-04-13 02:47 UTC (History)
9 users (show)

Fixed In Version: cockpit-appstream-289-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2180874 (view as bug list)
Environment:
Last Closed: 2023-01-21 07:27:40 UTC
Type: Bug
Target Upstream Version: 286
Embargoed:
xchen: needinfo? (kkoukiou)


Attachments (Terms of Use)

Description Xianghua Chen 2021-01-07 04:17:28 UTC
Description of problem: 
Can not accept mouse input correctly in vm console tab unless Expand it

Version-Release number of selected component (if applicable):
cockpit-machines-234-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with a ISO file(such as fedora*.iso), then install it with GUI

2. During the installation, click the content per the installation guide in Console tab, can not click on the button you really want to click.
You can also check that in an existing running vm with GUI, the mouse seems like not in the right position.

3. Expand the Console into a separate page, everything is normal now.


Actual results:
In step 2, There is a gap between the mouse on the screen and the actual position in the vm,  I mean you can't click on the button you want to click.

But all click is good in step 3.


Expected results:
In step 2, the mouse click should work fine.

Additional info:

Comment 1 Garrett LeSage 2021-01-21 18:08:40 UTC
Thanks for reporting this issue!

I couldn't reproduce it here on either Firefox or Chrome — with the window maximized. When I resized my window where it would scale the embedded VNC viewer, it started to have some issues.

This problem isn't actually related to the window being embedded or expanded. It's an issue where the mouse offset is calculated from the top-left origin and it counts pixels. However, when the internal resolution differs from the on-screen resolution (that is: the view is scaled), the offset is incorrect. It should be taking into consideration the screen size versus the scaled screen size... but it doesn't. Instead of using pixels, it should be using percentages or a multiplier.

Hopefully someone with familiarity in the VNC codebase can help to figure out a working solution.

Comment 2 Xianghua Chen 2021-09-13 08:38:00 UTC
Bug 2001730 may provided more details for this bug, please take a look whether it' the same problem.

Comment 4 RHEL Program Management 2022-07-07 07:27:23 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 6 Xianghua Chen 2022-09-15 06:51:50 UTC
Sometimes the whole console tab is not fully shown and I'm blocked when installing. Current we can use Desktop viewer to workaround, and hopefully it can be improved when new implement method is ready.

Comment 8 RHEL Program Management 2023-01-21 07:27:40 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 11 Simon Kobyda 2023-02-16 08:43:09 UTC
Not reproducable to me, it may have been fixed by this PR: https://github.com/cockpit-project/cockpit-machines/pull/893

Comment 17 Simon Kobyda 2023-03-16 13:46:54 UTC
Fix merged: https://github.com/cockpit-project/cockpit-machines/pull/900

Comment 22 Xianghua Chen 2023-04-13 02:39:04 UTC
Verified with packages:
cockpit-machines-289-1.el8.noarch
libvirt-8.0.0-19.module+el8.8.0+18453+e0bf0d1d.x86_64
libvirt-dbus-1.3.0-2.module+el8.8.0+16781+9f4724c2.x86_64

Steps to Reproduce:
1. Create a VM with a ISO file(such as fedora*.iso), then install it with GUI
2. During the installation, click the content per the installation guide in Console tab, click works fine
3. Expand the Console into a separate page, click works fine


So verified.


Note You need to log in before you can comment on or make changes to this bug.