Bug 19141
| Summary: | patch: xmms 1.2.x can't play mp3s | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Need Real Name <scorpio> | ||||
| Component: | xmms | Assignee: | Bill Nottingham <notting> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.2 | CC: | rvokal | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | alpha | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2000-10-15 17:29:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 4171 [details]
patch to fix xmms/mpg123
will be fixed in 1.2.3-2, which should be in next rawhide release. Actually, xmms and mpg123 were working fine with gcc 2.96 without this patch. |
xmms 1.2.x's mpg123 input plugin can't properly play mp3s. It is a bug in the layer3 decoder which affects alphas (and probably other 64-bit architectures). The problem exists in the latest released version of mpg123, and was introduced to xmms when it upgraded the plugin to the latest version of mpg123. The problem has been fixed in the mpg123 cvs, and that is from where this patch comes. --- xmms-1.2.3/Input/mpg123/layer3.c.orig Wed Aug 2 06:47:50 2000 +++ xmms-1.2.3/Input/mpg123/layer3.c Fri Oct 13 00:05:16 2000 @@ -637,7 +637,7 @@ #define REFRESH_MASK() \ while(num < BITSHIFT) { \ - mask |= mpg123_getbyte() << (BITSHIFT - num); \ + mask |= ((unsigned long)mpg123_getbyte()) << (BITSHIFT - num); \ num += 8; \ part2remain -= 8; \ }