Bug 1916418 - [RFE] Add support for netlink extack error msgs
Summary: [RFE] Add support for netlink extack error msgs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Fast Datapath
Classification: Red Hat
Component: openvswitch
Version: FDP 21.A
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
: FDP 21.E
Assignee: Paolo Valerio
QA Contact: qding
URL:
Whiteboard:
Depends On:
Blocks: 1826393 2018001
TreeView+ depends on / blocked
 
Reported: 2021-01-14 18:11 UTC by Marcelo Ricardo Leitner
Modified: 2022-07-22 13:19 UTC (History)
5 users (show)

Fixed In Version: openvswitch2.17-2.17.0-3.el8fdp
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-22 13:19:47 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FD-1027 0 None None None 2021-08-09 13:03:10 UTC

Description Marcelo Ricardo Leitner 2021-01-14 18:11:15 UTC
Description of problem:
Currently, OVS doesn't request extack messages when dealing with netlink communication. OVS kernel datapath doesn't make use of it, tc does and supporting it can enhance the visibility of issues on tc layer.

So that it can log errors that are more meaningful than:
2021-01-14T13:13:02.790Z|00202|netlink_socket(handler13)|DBG|received NAK error=0 (Invalid argument)

Pretty much the whole tc is using this construct:
                          if (type && type != TUNNEL_GENEVE_OPT) {
                                  NL_SET_ERR_MSG(extack, "Duplicate type for geneve options");
                                  return -EINVAL;
                          }

Logging that error message is important for the admin to understand why it failed to add the flow to tc.

Version-Release number of selected component (if applicable):
checked on ovs 78e712c0b1da ("lldp: do not leak memory on multiple instances of TLVs")


On a parallel note, I'm looking into adding kernel trace points on NL_SET_ERR_MSG(), so that diagnosing the kernel doesn't rely on the userspace that much.

Comment 1 Marcelo Ricardo Leitner 2021-03-11 12:26:34 UTC
(In reply to Marcelo Ricardo Leitner from comment #0)
> On a parallel note, I'm looking into adding kernel trace points on
> NL_SET_ERR_MSG(), so that diagnosing the kernel doesn't rely on the
> userspace that much.

This part is done: https://github.com/torvalds/linux/commit/7e3ce05e7f650371061d0b9eec1e1cf74ed6fca0
and can be used to double check the implementation of the ovs change.

Comment 9 Paolo Valerio 2022-01-17 20:10:01 UTC
Applied to master. Will be included in 2.17


Note You need to log in before you can comment on or make changes to this bug.