Bug 1916418
| Summary: | [RFE] Add support for netlink extack error msgs | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Fast Datapath | Reporter: | Marcelo Ricardo Leitner <mleitner> |
| Component: | openvswitch | Assignee: | Paolo Valerio <pvalerio> |
| openvswitch sub component: | daemons and tools | QA Contact: | qding |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | unspecified | CC: | ctrautma, egarver, hakhande, jhsiao, tredaelli |
| Version: | FDP 21.A | ||
| Target Milestone: | --- | ||
| Target Release: | FDP 21.E | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | openvswitch2.17-2.17.0-3.el8fdp | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-22 13:19:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1826393, 2018001 | ||
(In reply to Marcelo Ricardo Leitner from comment #0) > On a parallel note, I'm looking into adding kernel trace points on > NL_SET_ERR_MSG(), so that diagnosing the kernel doesn't rely on the > userspace that much. This part is done: https://github.com/torvalds/linux/commit/7e3ce05e7f650371061d0b9eec1e1cf74ed6fca0 and can be used to double check the implementation of the ovs change. posted upstream: https://patchwork.ozlabs.org/project/openvswitch/patch/162820055142.23997.13047328062582665150.stgit@fed.void/ Applied to master. Will be included in 2.17 |
Description of problem: Currently, OVS doesn't request extack messages when dealing with netlink communication. OVS kernel datapath doesn't make use of it, tc does and supporting it can enhance the visibility of issues on tc layer. So that it can log errors that are more meaningful than: 2021-01-14T13:13:02.790Z|00202|netlink_socket(handler13)|DBG|received NAK error=0 (Invalid argument) Pretty much the whole tc is using this construct: if (type && type != TUNNEL_GENEVE_OPT) { NL_SET_ERR_MSG(extack, "Duplicate type for geneve options"); return -EINVAL; } Logging that error message is important for the admin to understand why it failed to add the flow to tc. Version-Release number of selected component (if applicable): checked on ovs 78e712c0b1da ("lldp: do not leak memory on multiple instances of TLVs") On a parallel note, I'm looking into adding kernel trace points on NL_SET_ERR_MSG(), so that diagnosing the kernel doesn't rely on the userspace that much.