Bug 1918946 - smartmontools package installs possibly incompatible drivedb.h from SVN trunk
Summary: smartmontools package installs possibly incompatible drivedb.h from SVN trunk
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: smartmontools
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-21 18:31 UTC by Christian Franke
Modified: 2021-02-05 01:32 UTC (History)
2 users (show)

Fixed In Version: smartmontools-7.2-2.fc32 smartmontools-7.2-2.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-29 02:34:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christian Franke 2021-01-21 18:31:00 UTC
Description of problem:
According to smartmontools.spec file, the current drivedb.h from SVN trunk is downloaded before build.  This version might be no longer compatible with the latest smartmontools release.
For example, the current trunk version uses new '-d sntasmedia' option which is not supported by 7.2. This does not result in a syntax error message but later enhancements of '-v' options would.

Version-Release number of selected component (if applicable):
smartmontools-7.2-1.fc33

Steps to Reproduce:
$ grep VERSION: /usr/share/smartmontools/drivedb.h

Actual results:
  { "VERSION: 7.3 $Id: drivedb.h 5170 2021-01-17 16:11:20Z chrfranke $",

Expected results:
  { "VERSION: 7.2/5170 2021-01-17 16:11:20 $Id: drivedb.h 5171 ... $",

Additional info:
"VERSION:" is a recent addition, see
https://www.smartmontools.org/ticket/1424.

Sample function to extract branch version from source and download drivedb:

get_latest_drivedb()
{
  local v
  v=$(tar -x --to-stdout --wildcards -f "$1" "*/configure.ac" |
      sed -n 's,^smartmontools_drivedb_version=,,p' | tr '.' '_')
  test -n "$v" || ! echo "$1: db version not found" || return 1
  curl -H "Accept-Encoding: identity" -o "$2" "\
https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/\
RELEASE_${v}_DRIVEDB/smartmontools/drivedb.h?format=raw"
}

get_latest_drivedb smartmontools-7.2.tar.gz drivedb.h


Alternatively build and run the update script:

get_latest_drivedb()
{
  local rc=0
  mkdir build || return 1
  cat "$1" | ( cd build && tar -x -z -f - && cd smartmontools-* &&
  ./configure && make update-smart-drivedb ) || return 1
  build/smartmontools-*/update-smart-drivedb -s - -u sf "$2" || rc=$?
  rm -rf build
  return $rc
}

This would also check file integrity with GnuPG.

Comment 1 Michal Hlavinka 2021-01-25 20:24:55 UTC
Thanks for reporting this

Comment 2 Fedora Update System 2021-01-27 11:18:45 UTC
FEDORA-2021-7a23508bb6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a23508bb6

Comment 3 Fedora Update System 2021-01-27 11:18:47 UTC
FEDORA-2021-0bd0192880 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0bd0192880

Comment 4 Fedora Update System 2021-01-28 01:54:03 UTC
FEDORA-2021-0bd0192880 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0bd0192880`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0bd0192880

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2021-01-28 04:13:48 UTC
FEDORA-2021-7a23508bb6 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7a23508bb6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a23508bb6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-01-29 02:34:47 UTC
FEDORA-2021-0bd0192880 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2021-02-05 01:32:14 UTC
FEDORA-2021-7a23508bb6 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.