Bug 1924354 - %{gourl} is broken if %{goipath} has "/v" suffix
Summary: %{gourl} is broken if %{goipath} has "/v" suffix
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: go-rpm-macros
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Nicolas Mailhot
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-03 00:42 UTC by Tim Landscheidt
Modified: 2023-03-07 16:57 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-13 15:17:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tim Landscheidt 2021-02-03 00:42:32 UTC
Five Go binary packages in Fedora 32 have URL tags that end with a "/v" suffix:

| [tim@passepartout ~]$ dnf -q repoquery golang-github-casbin-2-devel golang-github-d5-tengo-2-devel golang-github-d5-tengo-2 golang-github-urfave-cli-2-devel | golang-github-vbauerster-mpb-5-devel --queryformat '%{NAME}: %{URL}' 
| golang-github-casbin-2-devel: https://github.com/casbin/casbin/v2
| golang-github-d5-tengo-2-devel: https://github.com/d5/tengo/v2
| golang-github-d5-tengo-2: https://github.com/d5/tengo/v2
| golang-github-urfave-cli-2-devel: https://github.com/urfave/cli/v2
| golang-github-vbauerster-mpb-5-devel: https://github.com/vbauerster/mpb/v5
| [tim@passepartout ~]$

Those URLs are "404 Page not found".  The suffix seems to come from %{goipath}:

| [tim@passepartout ~/src/fedora/rpms]$ grep '^\(%global goipath\|URL:\)' {golang-github-casbin-2,golang-github-d5-tengo-2,golang-github-urfave-cli-2,golang-github-vbauerster-mpb-5}/*.spec
| golang-github-casbin-2/golang-github-casbin-2.spec:%global goipath         github.com/casbin/casbin/v2
| golang-github-casbin-2/golang-github-casbin-2.spec:URL:            %{gourl}
| golang-github-d5-tengo-2/golang-github-d5-tengo-2.spec:%global goipath         github.com/d5/tengo/v2
| golang-github-d5-tengo-2/golang-github-d5-tengo-2.spec:URL:            %{gourl}
| golang-github-urfave-cli-2/golang-github-urfave-cli-2.spec:%global goipath         github.com/urfave/cli/v2
| golang-github-urfave-cli-2/golang-github-urfave-cli-2.spec:URL:            %{gourl}
| golang-github-vbauerster-mpb-5/golang-github-vbauerster-mpb-5.spec:%global goipath         github.com/vbauerster/mpb/v5
| golang-github-vbauerster-mpb-5/golang-github-vbauerster-mpb-5.spec:URL:            %{gourl}
| [tim@passepartout ~/src/fedora/rpms]$

I don't know the semantics of the suffix in %{goipath}, but I assume that it can and should be chopped off in %{gourl}.

Comment 1 Robert-André Mauchin 🐧 2021-02-04 23:23:52 UTC
These should use a %global forgeurl 

Here's a list of potentially affected packages:

fd "golang-github-.*-\d" -t d
golang-github-acme-lego-3
golang-github-alecthomas-kong-hcl-2
golang-github-apparentlymart-textseg-12
golang-github-aws-sdk-2
golang-github-aws-sdk-2-0.24
golang-github-caddyserver-caddy-1
golang-github-casbin-2
golang-github-census-instrumentation-opencensus-proto-0.2
golang-github-d5-tengo-2
golang-github-elastic-elasticsearch-6
golang-github-evanw-esbuild-0.8.20
golang-github-git-lfs-gitobj-2
golang-github-golangci-lint-1
golang-github-googleapis-gnostic-0.4
golang-github-hashicorp-hcl-2
golang-github-jackc-chunkreader-2
golang-github-jackc-pgx-3
golang-github-jeffail-gabs-2
golang-github-labstack-echo-4
golang-github-marten-seemann-qtls-go1-15
golang-github-marten-seemann-qtls-go1-16
golang-github-maruel-panicparse-2
golang-github-masterminds-semver-1
golang-github-mholt-certmagic-0.8
golang-github-mholt-certmagic-0.9
golang-github-minio-6
golang-github-nicksnyder-i18n-2
golang-github-oracle-oci-sdk-24
golang-github-playground-assert-2
golang-github-playground-validator-10
golang-github-posener-complete-2
golang-github-prometheus-client-0.9
golang-github-qingstor-sdk-4
golang-github-redis-8
golang-github-schollz-progressbar-2
golang-github-schollz-progressbar-3
golang-github-urfave-cli-2
golang-github-vbauerster-mpb-5
golang-github-vmihailenco-msgpack-4
golang-github-zmap-zlint-2
golang-github-zmap-zlint-3

This is not a high priority right now, I'll take a look when I have the time.

Comment 2 Fedora Program Management 2021-04-29 17:12:07 UTC
This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Tim Landscheidt 2021-04-30 14:31:11 UTC
| [tim@passepartout ~]$ dnf -q --repo=rawhide repoquery golang-github-casbin-2-devel golang-github-d5-tengo-2-devel golang-github-d5-tengo-2 --queryformat '%{NAME}: %{URL}'
| golang-github-casbin-2-devel: https://github.com/casbin/casbin/v2
| golang-github-d5-tengo-2-devel: https://github.com/d5/tengo/v2
| golang-github-d5-tengo-2: https://github.com/d5/tengo/v2
| [tim@passepartout ~]$

Comment 4 Ben Cotton 2021-08-10 13:44:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 5 Ben Cotton 2022-11-29 16:51:37 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 6 Ben Cotton 2022-12-13 15:17:27 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 7 Tim Landscheidt 2023-03-07 16:57:13 UTC
(In reply to Robert-André Mauchin 🐧 from comment #1)
> These should use a %global forgeurl 
> […]

Just to clarify: Do you mean that %{goipath} works as designed and those packages where its use produces invalid URLs need to be updated to additionally set %{forgeurl}?


Note You need to log in before you can comment on or make changes to this bug.