Bug 192611 - xvattr: $RPM_OPT_FLAGS not honored
Summary: xvattr: $RPM_OPT_FLAGS not honored
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: xvattr
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Saou
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-05-21 21:36 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: 1.3-10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-23 09:23:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ville Skyttä 2006-05-21 21:36:01 UTC
xvattr's build doesn't appear to be honoring $RPM_OPT_FLAGS, reusulting in
compiler security features not being used and a more or less useless debuginfo
package.  More info: http://fedoraproject.org/wiki/Packaging/Debuginfo

Possible fix, in %prep:
sed -i -e 's/^\(CFLAGS\s*=.*\)/\1 $(RPM_OPT_FLAGS)/' Makefile*

Comment 1 Matthias Saou 2006-05-23 09:23:02 UTC
I don't like exposing RPM_OPT_FLAGS inside generic sources, so I've done this
instead (same result of course) :

# Append GTK CFLAGS to CFLAGS instead of overwriting CFLAGS (optflags get used)
%{__perl} -pi -e 's|^CFLAGS = (.*)|CFLAGS += $1|g' Makefile*

Packages for FC-4, FC-5 and devel will be rebuilt now.


Note You need to log in before you can comment on or make changes to this bug.