Bug 1928109 - Ffmpegthumbnailer and Mysql support disabled
Summary: Ffmpegthumbnailer and Mysql support disabled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gerbera
Version: 33
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-12 12:26 UTC by Matthias
Modified: 2021-02-21 01:20 UTC (History)
2 users (show)

Fixed In Version: gerbera-1.6.4-5.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-21 01:20:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Matthias 2021-02-12 12:26:55 UTC
Description of problem:
Ffmpegthumbnailer and Mysql support are disabled in the compiler options. It would be good if those options could be enabled.

Version-Release number of selected component (if applicable):
gerbera-1.6.1-1.fc33.x86_64

How reproducible:
Always

Steps to Reproduce:
1. run "gerbera-1.6.1-1.fc33.x86_64"

Actual results:
===============================================================================
Gerbera is free software, covered by the GNU General Public License version 2

Copyright 2016-2020 Gerbera Contributors.
Gerbera is based on MediaTomb: Copyright 2005-2010 Gena Batsyan, Sergey Bostandzhyan, Leonhard Wimmer.
===============================================================================
Compile info
-------------
WITH_MAGIC=1
WITH_MYSQL=0
WITH_CURL=1
WITH_INOTIFY=1
WITH_JS=1
WITH_TAGLIB=1
WITH_AVCODEC=0
WITH_FFMPEGTHUMBNAILER=0
WITH_EXIF=1
WITH_EXIV2=1
WITH_PROTOCOL_EXTENSIONS=
WITH_SYSTEMD=1
WITH_LASTFM=0
WITH_DEBUG=1
WITH_TESTS=0


Expected results:
WITH_MYSQL=1
WITH_FFMPEGTHUMBNAILER=1

Additional info:

Comment 1 Gwyn Ciesla 2021-02-12 15:31:32 UTC
Hi! I'll get out an update with MySQL support enabled. We can't enable ffmpegthumbnailer, because we can't add a dependency on something we can't ship in Fedora.

Comment 2 Fedora Update System 2021-02-12 15:58:25 UTC
FEDORA-2021-39c3d7d624 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-39c3d7d624

Comment 3 Matthias 2021-02-13 00:29:24 UTC
Thank you for the MySQL support!

Let me try to argue my case for the ffmpegthumbnailer switch. I understand that you cannot add a dependency to the ffmpegthumbnailer rpm because it is not in the Fedora repo.

But from my point of view this is not necessary. All that should be changed is the compiler switch. That will have no impact on the "normal" user. With default settings the function is disabled: https://docs.gerbera.io/en/stable/config-extended.html

Currently it is not even listed in the config.xml.

In order to use it the user needs to:
1. read the documentation
2. change the settings in /etc/gerbera/config.xml
3. install the ffmpegthumbnailer rpm from rpmfusion (I guess a majority of users has those repos enabled anyway)

Other Fedora software packages support functionalities that only work when non-Fedora rpm's are present. First thing that comes to mind is codec support, e.g. mp3. 

If I am not wrong ffmpegthumbnailer is optionally used by KDE and Gnome to create thumbnails. Gerbera wouldn't be the first Fedora software to use it.

Disadvantage of changing the switch: None
Advantage: People who want to tinker have more options

Comment 4 Fedora Update System 2021-02-13 01:39:20 UTC
FEDORA-2021-39c3d7d624 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-39c3d7d624`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-39c3d7d624

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Matthias 2021-02-13 02:24:20 UTC
I have installed the new version and tested MySQL support. It works as expected.

Question: Does it make sense to put some default values for mysql into the <storage> section of /etc/gerbera/config.xml? It could be commented out, but would make it easier to get it up and running.

For reference here the steps taken:
----------------------------------
1. Have MariaDB up and running
2. Create database and user
   a: mysql -u root
   b: CREATE DATABASE gerbera_db;
   c: CREATE USER 'gerbera_user'@'localhost' IDENTIFIED BY 'gerbera_user';
   d: GRANT ALL PRIVILEGES ON gerbera_db.* TO 'gerbera_user'@'localhost';
   e: FLUSH PRIVILEGES;
   f: EXIT;
3. Create tables 
   (not sure if necessary, Gerbera manual mentions: "If Gerbera was compiled with database auto creation the tables will be created automatically during the first startup.")

   mysql -u root -p gerbera_db < /usr/share/gerbera/mysql.sql

4. Edit /etc/gerbera/config.xml
   Change <storage> section to look like this:

   <storage>
     <sqlite3 enabled="no">
      <database-file>gerbera.db</database-file>
     </sqlite3>
   <mysql enabled="yes">
     <host>localhost</host>
     <port>0</port>
     <username>gerbera_user</username>
     <password>gerbera_user</password>
     <database>gerbera_db</database>
      </mysql>
    </storage>
----------------------------------

Instructions used:
https://docs.gerbera.io/en/latest/run.html#using-mysql-database
https://docs.gerbera.io/en/latest/config-server.html#storage

Comment 6 Gwyn Ciesla 2021-02-16 17:19:22 UTC
I'll consider the mysql config options.

Re: ffmpegthumbnailer, what happens if someone runs gerbera with it enabled at compile time, but doesn't have ffmpegthumbnailer intalled or configured in the gerbera config?

Comment 7 Matthias 2021-02-17 03:38:57 UTC
(In reply to Gwyn Ciesla from comment #6)
> I'll consider the mysql config options.
> 
> Re: ffmpegthumbnailer, what happens if someone runs gerbera with it enabled
> at compile time, but doesn't have ffmpegthumbnailer intalled or configured
> in the gerbera config?

I have raised the question about the behaviour of the software on the gerbera github page: https://github.com/gerbera/gerbera/discussions/1234

Hopefully we get some answers from the developers.

Comment 8 Matthias 2021-02-17 09:31:12 UTC
I rest my case regarding ffmpegthumbnailer after reading the answer from the maintainer of gerbera: "Gerbera will not start if the library is missing, as the linker will complain."

Thank you again for the MySQL support!

Comment 9 Fedora Update System 2021-02-21 01:20:04 UTC
FEDORA-2021-39c3d7d624 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.