Bug 1939018 - clang-format-diff is not in a PATH
Summary: clang-format-diff is not in a PATH
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: clang
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Tom Stellard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-15 13:12 UTC by Ray Kinsella
Modified: 2021-10-02 03:23 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-10-02 03:23:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ray Kinsella 2021-03-15 13:12:08 UTC
Description of problem:

clang-format-diff.py is not being installed to a PATH, it is being placed in the /usr/share/clang directory. This means that heroics are required to find and execute it on Fedora, which are not required on other OSs. 

Please see this Gerrit for an example of the required heroics. 

https://gerrit.fd.io/r/c/vpp/+/31633

Version-Release number of selected component (if applicable):

Clang 10 / Fedora 32 & 33

How reproducible:

[root@xyz vpp]# clang-format-diff
-bash: clang-format-diff: command not found
[root@xyz vpp]# ls -l /usr/share/clang/clang-format-diff.py
-rwxr-xr-x. 1 root root 4588 Jul  7  2020 /usr/share/clang/clang-format-diff.py

Comment 1 Tom Stellard 2021-04-14 02:53:28 UTC
Proposed fix: https://src.fedoraproject.org/rpms/clang/pull-request/104

Comment 2 Fedora Update System 2021-05-14 12:50:35 UTC
FEDORA-2021-6ee48cc231 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ee48cc231

Comment 3 Fedora Update System 2021-05-14 18:35:07 UTC
FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6ee48cc231`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ee48cc231

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2021-05-22 01:07:49 UTC
FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Tom Stellard 2021-10-02 03:23:56 UTC
(In reply to Fedora Update System from comment #4)
> FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 stable repository.
> If problem still persists, please make note of it in this bug report.

This means it has been fixed.


Note You need to log in before you can comment on or make changes to this bug.