Bug 1942317 - Missing Supplements tags for langpacks
Summary: Missing Supplements tags for langpacks
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: libreoffice
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-24 07:04 UTC by Akira TAGOH
Modified: 2021-03-25 02:53 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-25 02:53:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Akira TAGOH 2021-03-24 07:04:39 UTC
Description of problem:
All the application specific-langpacks sub-packages are supposed to be installed through langpacks packages . To make it possible, all the application specific-langpacks sub-packages needs to have Supplements tag in their spec file. libreoffice is missing it. so libreoffice-langpack-* packages won't be pulled by dnf install langpacks-*.

Version-Release number of selected component (if applicable):
7.1.0.3-3.fc34

How reproducible:
always

Steps to Reproduce:
1.make sure libreoffice is installed and no langpacks installed for French (on English system say)
2.dnf install langpacks-fr
3.

Actual results:
$ rpm -q libreoffice-core libreoffice-langpack-fr
libreoffice-core-7.1.0.3-3.fc34.x86_64
package libreoffice-langpack-fr is not installed
$ dnf install langpacks-fr
Dependencies resolved.
=======================================================================================================================
 Package                               Architecture          Version                      Repository              Size
=======================================================================================================================
Installing:
 langpacks-fr                          noarch                3.0-14.fc34                  updates-testing         10 k
Installing dependencies:
 langpacks-core-font-fr                noarch                3.0-14.fc34                  updates-testing         10 k
 langpacks-core-fr                     noarch                3.0-14.fc34                  updates-testing         10 k
Installing weak dependencies:
 hunspell-fr                           noarch                6.2-7.fc34                   fedora                 303 k
 hyphen-fr                             noarch                3.0-8.fc34                   updates-testing         17 k
 man-pages-fr                          noarch                4.9.2-3.fc34                 fedora                 3.8 M
 mythes-fr                             noarch                2.3-17.fc34                  fedora                 987 k

Transaction Summary
=======================================================================================================================
Install  7 Packages

Total download size: 5.2 M
Installed size: 10 M
Is this ok [y/N]: 

Expected results:
libreoffice-langpack-fr should be in the list.

Additional info:
not tested but we may want to add something like this:
diff --git a/libreoffice.spec b/libreoffice.spec
index eb3dc6f..4763447 100644
--- a/libreoffice.spec
+++ b/libreoffice.spec
@@ -735,6 +735,7 @@ Requires: %{name}-core%{?_isa} = %{epoch}:%{version}-%{release} \
 %{-f:Requires: font(:lang=%{-f*})}%{!-f:%{-F:Requires: font(:lang=%{lang})}} \
 %else \
 %{-f:Recommends: langpacks-%{-f*}}%{!-f:%{-F:Recommends: langpacks-%{lang}}} \
+%{-f:Supplements: (libreoffice-core and langpacks-%{-f*})}%{!-f:%{-F:Supplements: (libreoffice-core and langpacks-%{la
ng})}} \
 %endif \
 %{-h:Requires: hunspell-%{-h*}}%{!-h:%{-H:Requires: hunspell-%{lang}}} \
 %{-m:Requires: mythes-%{-m*}}%{!-m:%{-M:Requires: mythes-%{lang}}} \

Comment 1 Jens Petersen 2021-03-24 07:24:33 UTC
Interesting, since I got the langpacks installed automatically via gnome-software.

Comment 2 Parag Nemade 2021-03-24 07:31:40 UTC
Works fine for me at least in rawhide. 
Also check this https://koji.fedoraproject.org/koji/rpminfo?rpmID=25481698
Supplements tag exists.

Comment 3 Jens Petersen 2021-03-24 07:39:22 UTC
Wonder what is going on - it also works for me anyway:

$ LANG=C.utf8 sudo dnf --assumeno install langpacks-fr | grep fr
 langpacks-fr              noarch   3.0-14.fc34         updates-testing    10 k
 autocorr-fr               noarch   1:7.1.1.2-1.fc34    updates-testing    79 k
 hunspell-fr               noarch   6.2-7.fc34          fedora            303 k
 langpacks-core-font-fr    noarch   3.0-14.fc34         updates-testing    10 k
 langpacks-core-fr         noarch   3.0-14.fc34         updates-testing    10 k
 mythes-fr                 noarch   2.3-17.fc34         fedora            987 k
 glibc-langpack-fr         x86_64   2.33-5.fc34         updates-testing   706 k
 hyphen-fr                 noarch   3.0-8.fc34          updates-testing    17 k
 libreoffice-help-fr       x86_64   1:7.1.1.2-1.fc34    updates-testing   3.3 M
 libreoffice-langpack-fr   x86_64   1:7.1.1.2-1.fc34    updates-testing   907 k
 man-pages-fr              noarch   4.9.2-3.fc34        fedora            3.8 M

Comment 4 Caolan McNamara 2021-03-24 10:00:18 UTC
we already have

%{-p:Supplements: (%{name}-core%{?_isa} and langpacks-%{-p*})} \
%{!-p:Supplements: (%{name}-core%{?_isa} and langpacks-%{lang})} \

in the spec, and the (libreoffice-core(x86-64) and langpacks-fr) in #2 suggests that's in action

I presume:
dnf repoquery --whatsupplements langpacks-fr|grep libreoffice
is listing libreoffice-langpack-fr
?

Comment 5 Caolan McNamara 2021-03-24 10:09:45 UTC
what about if you do a dnf update *before* then trying dnf install langpacks-fr ?

Comment 6 Akira TAGOH 2021-03-25 02:53:19 UTC
Ah, sorry for confusion. that is it. it works after updating.


Note You need to log in before you can comment on or make changes to this bug.