Description of problem: Powerstore driver in 16.1 doe snot support consistency groups. It had landed in Wallaby. https://review.opendev.org/c/openstack/cinder/+/775090 Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Can we target it to RHOSP-16.2? it had landed in Wallaby upstream. It cannot be backported upstream since it is new functionality.
small update, we at Dell are working on a separation of Wallaby patches to make backport of consistency groups feasible. The patch should fit 16.2 (Train). Please, expect the patch in a few days after we re-test it locally. Thanks, Vlad
Created attachment 1788964 [details] Patch for Dell EMC PowerStore Cinder driver with consistency groups included. This patch also contains https://review.opendev.org/c/openstack/cinder/+/783933/
@gcharot a patch with only consistency groups included is provided above. Please let us know if there is anything else needed.
(In reply to Ivan Pchelintsev from comment #11) > Created attachment 1788964 [details] > Patch for Dell EMC PowerStore Cinder driver with consistency groups included. > > This patch also contains > https://review.opendev.org/c/openstack/cinder/+/783933/ Thanks for the patch format, now just for clarification Fix PowerStore iSCSI targets filtering was already merged for the 16.2 branch by rhbz#1953749 including builds, so for wording the patch was created with the chain relationship on top of https://review.opendev.org/c/openstack/cinder/+/783933/ that would be part of the GA for 16.2 (if this is not correct, feel free to correct me). Back to the consistency groups current patch provided (without the volume replication v2.1 patch) is currently being reviewed for 16.2.1 (z1 kind) we already passed the time for GA. Regards,
(In reply to Ivan Pchelintsev from comment #11) Hi Ivan, going through my backlog, Did a quick check between the patch file provided Change-Id: I5598d006862a102bb32331d84104baa64e26bd2d 7 --- 8 .../drivers/dell_emc/powerstore/adapter.py | 560 ++++++++++++------ 9 .../drivers/dell_emc/powerstore/client.py | 262 ++++++-- 10 .../drivers/dell_emc/powerstore/driver.py | 40 +- 11 .../drivers/dell_emc/powerstore/options.py | 7 +- 12 .../drivers/dell_emc/powerstore/utils.py | 33 ++ 13 5 files changed, 670 insertions(+), 232 deletions(-) And the ones I did for a internal review around that time for https://review.opendev.org/c/openstack/cinder/+/773854 First thing noticed there, there is no modification for the test units as and one of the first things that would missing is the class 'cinder.volume.drivers.dell_emc.powerstore.client.PowerStoreClient' does not have the attribute 'get_appliance_id_by_name'" as not being adjusted as per wallaby code. Could you include those elements in your patch export? it should be done in a similar way to propose patches in the upstream branches. Just to be sure in the same page, - Verify pep8, unit tests, etc (you can check With Helen as she already verify other bugs with us using this methodology) - I highly suggest you do a TripleO deployment (Rajini can help) to verify the driver functions correctly in a real deployment - Update the commit message to summarize all of the changes associated with that single patch (driver version, list of features, bug fixes, etc.) Thanks for your cooperation and patience. Kind regards.
Dell EMC is now willing to wait until the feature arrives in OSP-17, and no backports are required for OSP-17 as the code is already present in upstream Wallaby. I'm closing the backport request for OSP-16.2