Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1942717

Summary: [Backport] Powerstore support for Consistency Groups
Product: Red Hat OpenStack Reporter: arkady kanevsky <arkady_kanevsky>
Component: openstack-cinderAssignee: Cinder Bugs List <cinder-bugs>
Status: CLOSED WONTFIX QA Contact: Tzach Shefi <tshefi>
Severity: medium Docs Contact: RHOS Documentation Team <rhos-docs>
Priority: medium    
Version: 16.2 (Train)CC: abishop, a.stripeikis, brian.rosmaita, eharney, gcharot, geguileo, Ivan.Pchelintsev, jvisser, kholtz, kurt_hey, lmarsh, ltoscano, morazi, pcaruana, pgrist, sam.wan, vladislav.belogrudov
Target Milestone: z4Keywords: OtherQA, Triaged
Target Release: 16.2 (Train on RHEL 8.4)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
This release supports port filtering for the Dell EMC XtremeIO driver for the Block Storage service (cinder).
 Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-21 16:08:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: Wallaby
Embargoed:
Bug Depends On:    
Bug Blocks: 1595325, 1715964    
Attachments:
Description Flags
Patch for Dell EMC PowerStore Cinder driver with consistency groups included. none

Description arkady kanevsky 2021-03-24 19:16:49 UTC 
Description of problem:
Powerstore driver in 16.1 doe snot support consistency groups.
It had landed in Wallaby.
https://review.opendev.org/c/openstack/cinder/+/775090

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 arkady kanevsky 2021-04-26 17:18:13 UTC 
Can we target it to RHOSP-16.2?
it had landed in Wallaby upstream.
It cannot be backported upstream since it is new functionality.
Comment 10 Vladislav Belogrudov 2021-06-03 15:38:58 UTC 
small update,

we at Dell are working on a separation of Wallaby patches to make backport of consistency groups feasible. The patch should fit 16.2 (Train). Please, expect the patch in a few days after we re-test it locally.

Thanks,
Vlad
Comment 11 Ivan Pchelintsev 2021-06-04 11:37:49 UTC 
Created attachment 1788964 [details]
Patch for Dell EMC PowerStore Cinder driver with consistency groups included.

This patch also contains https://review.opendev.org/c/openstack/cinder/+/783933/
Comment 12 a.stripeikis 2021-06-16 19:26:02 UTC 
@gcharot a patch with only consistency groups included is provided above. Please let us know if there is anything else needed.
Comment 13 Pablo Caruana 2021-06-18 09:51:51 UTC 
(In reply to Ivan Pchelintsev from comment #11)
> Created attachment 1788964 [details]
> Patch for Dell EMC PowerStore Cinder driver with consistency groups included.
> 
> This patch also contains
> https://review.opendev.org/c/openstack/cinder/+/783933/

Thanks for the patch format, now just for clarification Fix PowerStore iSCSI targets filtering was already merged for the 16.2 branch by rhbz#1953749 including  builds, so for wording the patch was created with the chain relationship on top of  https://review.opendev.org/c/openstack/cinder/+/783933/ that would be part of the GA for 16.2 (if this is not correct, feel free to correct me).

Back to the consistency groups current patch provided (without the  volume replication v2.1 patch) is currently being reviewed for  16.2.1 (z1 kind)  we already passed the time for GA.

Regards,
Comment 15 Pablo Caruana 2021-08-11 12:54:23 UTC 
(In reply to Ivan Pchelintsev from comment #11)

Hi Ivan, going through my backlog, Did a quick  check between the patch file provided  

Change-Id: I5598d006862a102bb32331d84104baa64e26bd2d
   7 ---
   8  .../drivers/dell_emc/powerstore/adapter.py    | 560 ++++++++++++------
   9  .../drivers/dell_emc/powerstore/client.py     | 262 ++++++--
  10  .../drivers/dell_emc/powerstore/driver.py     |  40 +-
  11  .../drivers/dell_emc/powerstore/options.py    |   7 +-
  12  .../drivers/dell_emc/powerstore/utils.py      |  33 ++
  13  5 files changed, 670 insertions(+), 232 deletions(-)

And the ones I did for a internal review around that time for  ​https://review.opendev.org/c/openstack/cinder/+/773854

First thing noticed there, there is no modification for the test units as and one of the first things that would missing is the class 'cinder.volume.drivers.dell_emc.powerstore.client.PowerStoreClient' does not have the attribute 'get_appliance_id_by_name'" as not being adjusted as per wallaby code.


Could you include those elements in your patch export?  it should be done in a similar way to propose patches in the upstream branches.
 
 Just to be sure in the same page,
- Verify pep8, unit tests, etc (you can check With Helen as she already verify other bugs with us using this methodology)
- I highly suggest you do a TripleO deployment (Rajini can help) to verify the driver functions correctly in a real deployment
- Update the commit message to summarize all of the changes associated with that single patch (driver version, list of features, bug fixes, etc.)

Thanks for your cooperation and patience.
Kind regards.
Comment 19 Alan Bishop 2022-04-21 16:08:10 UTC 
Dell EMC is now willing to wait until the feature arrives in OSP-17, and no backports are required for OSP-17 as the code is already present in upstream Wallaby.

I'm closing the backport request for OSP-16.2
Comment 20 Red Hat Bugzilla 2023-09-15 01:03:59 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days