This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Created attachment 1770502 [details]
This patch applies on downstream qemu.

Description of problem:

When VIRTIO_F_IN_ORDER feature is enabled, the guest and the host side both know that the buffers are used in order. This opens up optimization opportunities. The main goal is to enable it for net devices.

A few year ago, Ilya has posted a patch usptream that enables inorder blindly for all devices, but it should be checked that all devices that have this enabled actually use the buffers in order. See the discussion on the mailing list:

https://patchew.org/QEMU/1533833677-27512-1-git-send-email-i.maximets@samsung.com/

I have backported Ilya's patch to downstream Qemu and it works, except that I did not check if all the enabled devices actually use the buffers in order. See the attachment for the patch.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
1ULL << VIRTIO_F_IN_ORDER is not set in the feature bit

Expected results:
The feature bit should be enabled. In DPDK, the *_inorder( version of functions should be used, i.e. virtio_net_is_inorder should return true.

Additional info:

Assigned to Ariel for initial triage per bz process and age of bug created or assigned to virt-maint without triage.

Move RHEL-AV bugs to RHEL9. If necessary to resolve in RHEL8, then clone to the current RHEL8 release.  Removed the ITR from all bugs as part of the change.

Hello Eugenio Pérez Martín

Could you help review this bug, can it be fixed within 9.0.0 release.

(In reply to Quan Wenli from comment #7)
> Hello Eugenio Pérez Martín
> 
> Could you help review this bug, can it be fixed within 9.0.0 release.

Hi Wenli,

Moving to 9.1, since it is still not in upstream.

Thanks!

Implementing VIRTIO_F_IN_ORDER has been proposed as a QEMU Google Summer of Code project (thanks Jason Wang and Stefano Garzarella!):
https://wiki.qemu.org/Google_Summer_of_Code_2022#VIRTIO_F_IN_ORDER_support_for_virtio_devices

Ilya Maximets mentioned this BZ when we talked about the GSoC project. I wanted to post a comment so Eugenio knows about the GSoC project idea.

Moving to 9.2 since the development of this feature is not expected before summer

Bugzilla migrated to RHEL project: https://issues.redhat.com/browse/RHEL-332

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days