Bug 1955828 - sbkeysync returns zero when updating EFI variables fails
Summary: sbkeysync returns zero when updating EFI variables fails
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sbsigntools
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-30 22:16 UTC by Andrew Gunnerson
Modified: 2021-05-26 01:08 UTC (History)
1 user (show)

Fixed In Version: sbsigntools-0.9.4-4.fc35 sbsigntools-0.9.4-4.fc34 sbsigntools-0.9.4-3.fc33
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-17 10:34:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andrew Gunnerson 2021-04-30 22:16:18 UTC
Description of problem:

When sbkeysync tries to update EFI variables and fails to do so, it still exits with status code 0 because some return values aren't checked.

This is fixed upstream, but is not in a stable release: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/sbsigntools.git/commit/?id=f12484869c9590682ac3253d583bf59b890bb826

Would it be possible to update the Fedora package to include this patch?

Version-Release number of selected component (if applicable):

sbsigntools-0.9.4-3.fc34.x86_64

Comment 1 Fedora Update System 2021-05-17 10:33:12 UTC
FEDORA-2021-8561f388a9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8561f388a9

Comment 2 Fedora Update System 2021-05-17 10:34:28 UTC
FEDORA-2021-8561f388a9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 3 Fedora Update System 2021-05-17 10:41:22 UTC
FEDORA-2021-f93484e623 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f93484e623

Comment 4 Fedora Update System 2021-05-17 10:41:23 UTC
FEDORA-2021-9e00bd81e5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9e00bd81e5

Comment 5 Fedora Update System 2021-05-18 01:01:08 UTC
FEDORA-2021-f93484e623 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-05-18 01:35:02 UTC
FEDORA-2021-9e00bd81e5 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-9e00bd81e5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9e00bd81e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-05-26 01:08:12 UTC
FEDORA-2021-9e00bd81e5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.