Bug 1956159 - [RFE] Add option to pass "LEAPP_OVL_SIZE" variable with desired value in "Run upgrade via Leapp" job template
Summary: [RFE] Add option to pass "LEAPP_OVL_SIZE" variable with desired value in "Run...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Leapp integration
Version: 6.8.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Lucie Vrtelova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-03 05:16 UTC by Prakash Ghadge
Modified: 2023-09-18 00:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-20 08:43:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker SAT-2888 0 None None None 2023-01-19 21:24:14 UTC

Description Prakash Ghadge 2021-05-03 05:16:33 UTC
1. Proposed title of this feature request

>>  [RFE]  Add option to pass "LEAPP_OVL_SIZE" variable with desired value in "Run upgrade via Leapp" job template
 

3. What is the nature and description of the request?

>> Add option to pass " LEAPP_OVL_SIZE" variable with desired value in "Run upgrade via Leapp" job template so that user does not require it to set it on the host manually and then proceed with the RHEL8 upgrade. 

4. Why does the customer need this? (List the business requirements here)

>> To fully automate the RHEL7 to RHEL8 upgrade.

5. How would the customer like to achieve this? (List the functional requirements here)

>> By adding an option to pass "LEAPP_OVL_SIZE" variable with desired value in "Run upgrade via Leapp" job template

6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.

>>

7. Is there already an existing RFE upstream or in Red Hat Bugzilla?

>> No
 

8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?

>> No

9. Is the sales team involved in this request and do they have any additional input?

>> No

10. List any affected packages or components.

>> Job Templates

11. Would the customer be able to assist in testing this functionality if implemented?

>> Yes

Comment 1 Prakash Ghadge 2021-05-03 05:29:46 UTC
Additional Information -

While upgrading from the RHEL7 to RHEL8, the leapp upgrade fails with an error if an "XFS ftype=0 case" condition is met.(typical for systems installed with RHEL 7.4 or before) 
~~~
At least X MB more space needed on the </XXX> filesystem 
~~~

For more information please check 
~~~
[leapp] At least X MB more space needed on the </XXX> filesystem 
https://access.redhat.com/solutions/5057391
~~~

The solution is to set the LEAPP_OVL_SIZE variable with a larger value (computation is XXX + 2048 + some space for security).

But this needs to be done manually on all affected clients and completely and does not fit incomplete automation using satellite 6.

The solution for this issue is to add an option in "Run upgrade via Leapp" job template to pass the value of the LEAPP_OVL_SIZE variable based on the following conditions.

1. Check XFS file systems built with ftype=0 option. There is a check in "preupgrade check with leapp" which checks for the same. Maybe we can utilize that

If YES -
  Set the "LEAPP_OVL_SIZE"

If NO -
  Do Not set the "LEAPP_OVL_SIZE"


Current Workaround which is working fine. - 

- Satellite WebUI > Hosts > Job Template > In search box search  "Run upgrade via Leapp" > Clone the template by clicking on drop-down menu next to run button
- Here modify the code as follows and save
~~~
---
- hosts: all
  tasks:
    - name: Populate Env
      lineinfile:
        dest: "/etc/environment"
        state: present
        line: "LEAPP_OVL_SIZE=4096"                <<< Set the value as per requirement.
    - name: Source ENV
      shell: "source /etc/environment"
    - name: Run Leapp Upgrade
      command: leapp upgrade
<%- if input('Reboot') == "true" -%>
    - name: Reboot the machine
      reboot:
        reboot_timeout: 1800
<%- end -%>
~~~

Comment 2 Adam Ruzicka 2021-07-13 14:10:17 UTC
Moving over to leapp. While the suggestion from #0 would probably work, permanently modifying system environment feels like something we should avoid if possible. Ansible allows setting environment variables on a per-task or per-play level, wouldn't this be enough?

Comment 3 Adam Ruzicka 2021-07-13 14:12:02 UTC
@Pavel sorry for pulling you into our BZs all the time, but opinions on #2?

Comment 4 Leos Stejskal 2022-07-20 08:43:00 UTC
Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team. Thank you.

Comment 5 Red Hat Bugzilla 2023-09-18 00:26:21 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days


Note You need to log in before you can comment on or make changes to this bug.