RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1956399 - scapy: Remove dependency on tox
Summary: scapy: Remove dependency on tox
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: scapy
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Andrea Claudi
QA Contact: Li Shuang
URL:
Whiteboard:
Depends On:
Blocks: 1887522 1918886
TreeView+ depends on / blocked
 
Reported: 2021-05-03 15:44 UTC by Miro Hrončok
Modified: 2021-12-07 21:35 UTC (History)
6 users (show)

Fixed In Version: scapy-2.4.4-3.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-07 21:33:05 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2021-05-03 15:44:17 UTC 
Please remove the dependency on tox, as tox is to be removed from RHEL 9.

If you cannot remove the dependency on tox, let us know ASAP, so we can decide on the best next step.

Thanks.
Comment 1 Miro Hrončok 2021-05-18 22:01:06 UTC 
Andrea, could you please respond here?
Comment 2 Miro Hrončok 2021-05-31 12:17:28 UTC 
Gentle ping here. We would like to remove tox, could you please remove the dependency? I can send a merge request, but this bugzilla lacks the necessary release+ flag.
Comment 3 Andrea Claudi 2021-05-31 13:19:31 UTC 
Hi Miro,
and sorry for the late answer. AFAICS, tox is needed to build the scapy-doc package, but if we can go without that there is no problem on my side on removing the tox dependency. Can you please confirm this?
Comment 4 Miro Hrončok 2021-05-31 13:57:29 UTC 
Since you asked me to verify, I've prepared the change in https://gitlab.com/redhat/centos-stream/rpms/scapy/-/merge_requests/1

However, it requires the release+ flag here.
Comment 5 Andrea Claudi 2021-05-31 14:08:47 UTC 
Thanks Miro, I have no objection to your patch.
Shuang, can you please consider to set qa_ack+ and ITM? Thanks!
Comment 6 Li Shuang 2021-06-01 02:31:44 UTC 
Hi Andrea,

Could you help to give some testing instructions?

Thanks,
Shuang
Comment 7 Andrea Claudi 2021-06-01 09:32:11 UTC 
Hi Shuang, sure. As this is a build dependency, you can:

1. clone the scapy package dist-git repo (http://pkgs.devel.redhat.com/cgit/rpms/scapy/) and switch to the rhel-9.0.0-beta branch
2. try to build the package with "rhpkg local" and verify it doesn't ask for python3-tox to be installed
Comment 8 Andrea Claudi 2021-06-01 09:33:16 UTC 
Switching it to ON_QA as the change already hit rhel-9.0.0-beta.
Comment 9 Tomas Orsava 2021-06-09 16:18:43 UTC 
(In reply to Andrea Claudi from comment #8)
> Switching it to ON_QA as the change already hit rhel-9.0.0-beta.

Hi Andrea, I have just checked the RHEL 9 Beta composes, and they still contain the old version of scapy (0:2.4.4-2) that still depends on tox. Could you please take a look? Perhaps it's stuck on gating.
Comment 10 Miro Hrončok 2021-06-09 16:31:27 UTC 
The latest RHEL9 build is scapy-2.4.4-2.el9. It is past gating but it does not yet contain the fix.

The situation in CentOS Stream 9 is the same.

The fixed commit https://gitlab.com/redhat/centos-stream/rpms/scapy/-/commit/71b7e779d245611341d1bcb0c9bf611aa21d4af9 has not yet been built.


(The testing instructions are not good enough, because they only test the state in git.)
Comment 12 Miro Hrončok 2021-06-15 12:05:28 UTC 
May I build the package? Or could you?
Comment 13 Adam Samalik 2021-06-17 11:52:48 UTC 
Getting this change built and included in the compose is one of two things that block the removal of ~120 packages from RHEL: https://issues.redhat.com/browse/RHELPLAN-84346
Comment 14 Andrea Claudi 2021-06-17 12:34:43 UTC 
Miro, for some reason I erroneously thought that merging the change was enough to trigger the build. Sorry about that and for the late answer, I was OoO for some days. I'll build the package today.
Comment 19 Miro Hrončok 2021-06-21 06:54:23 UTC 
Tox was a *build* dependency of scapy, hence installing scapy is not a good verification for this bugzilla.
Instead, repoquering the source repositories, verifying from the SRPM directly, or building the package in brew is a good verification.

OTOH there's no point to verify tox dependency is missing, the change was very explicit about that. Better to verify the generated documentation is still the same as before.

Anyway, the build i still stuck on gating.
Comment 20 Andrea Claudi 2021-06-21 14:29:09 UTC 
Gating issues solved asking osci team to manually restart tests. rpmdeplint failure seems to be unrelated to scapy, double-checking it before waiving.
Note You need to log in before you can comment on or make changes to this bug.