Bug 1958352 - Review Request: rust-libbpf-rs - Safe, idiomatic, and opinionated wrapper around libbpf-sys
Summary: Review Request: rust-libbpf-rs - Safe, idiomatic, and opinionated wrapper aro...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1958330 1958333 1958348
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-07 17:19 UTC by Davide Cavalca
Modified: 2021-08-04 22:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-04 22:47:38 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-05-07 17:19:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-libbpf-rs/rust-libbpf-rs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-libbpf-rs/rust-libbpf-rs-0.9.0-1.fc35.src.rpm

Description:
Safe, idiomatic, and opinionated wrapper around libbpf-sys.

Fedora Account System Username: dcavalca

Comment 1 Robert-André Mauchin 🐧 2021-05-09 17:42:01 UTC
 - Please add a comment explaining what changes you made in Cargo.toml

# Initial patched metadata
Patch0:         libbpf-rs-fix-metadata.diff

 - This shouldn't be necessary if you made the changes I told you about in the -sys package:

BuildRequires:  elfutils-libelf-devel
BuildRequires:  zlib-devel - Please ask upstream to add a LICENSE file in the crate


 - Please ask upstream to add a license file into the crate


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 2 Davide Cavalca 2021-05-10 19:18:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-libbpf-rs/rust-libbpf-rs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-libbpf-rs/rust-libbpf-rs-0.9.1-1.fc35.src.rpm

Changelog:
- Update to 0.9.1
- Update build requires
- Install license files

Comment 3 Robert-André Mauchin 🐧 2021-05-11 16:05:46 UTC
 - I'm looking for a more explicit comment

# Initial patched metadata
# * Bump libbpf-sys to 0.3.0-2
# * Bump vsprintf to 0.2
Patch0:         libbpf-rs-fix-metadata.diff

Ideally you would link to upstream PR mirroring those changes.


Package approved. Please fix the aformentioned issue before import.

Comment 4 Davide Cavalca 2021-05-11 16:08:50 UTC
Thanks!

$ fedpkg request-repo rust-libbpf-rs 1958352
https://pagure.io/releng/fedora-scm-requests/issue/33926

Comment 5 Gwyn Ciesla 2021-05-11 16:20:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libbpf-rs

Comment 6 Fedora Update System 2021-05-11 22:08:10 UTC
FEDORA-2021-efb45c264a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-efb45c264a

Comment 7 Fedora Update System 2021-05-12 07:05:57 UTC
FEDORA-2021-efb45c264a has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-efb45c264a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-efb45c264a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-05-20 01:11:46 UTC
FEDORA-2021-efb45c264a has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.