Bug 1959319 - [FTBFS] qt5-qtwebengine: FTBFS in rawhide
Summary: [FTBFS] qt5-qtwebengine: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: qt5-qtwebengine
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1945595 (view as bug list)
Depends On: 1945595
Blocks: 1937698
TreeView+ depends on / blocked
 
Reported: 2021-05-11 09:26 UTC by Jonathan Wakely
Modified: 2021-12-15 21:41 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-29 17:52:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
build.log (494.80 KB, text/plain)
2021-05-11 09:26 UTC, Jonathan Wakely
no flags Details
qtwebengine-release.sh (1.23 KB, application/x-shellscript)
2021-06-15 19:03 UTC, Kevin Kofler
no flags Details

Description Jonathan Wakely 2021-05-11 09:26:54 UTC
Created attachment 1781965 [details]
build.log

http://koji.fedoraproject.org/koji/buildinfo?buildID=1745776

Broken by glibc changes to SIGTKTSZ:

../../3rdparty/chromium/third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.cc -o obj/third_party/breakpad/client/exception_handler.o
../../3rdparty/chromium/third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.cc: In function 'void google_breakpad::{anonymous}::InstallAlternateStackLocked()':
../../3rdparty/chromium/third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.cc:141:49: error: no matching function for call to 'max(int, long int)'
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                         ~~~~~~~~^~~~~~~~~~~~~~~~~

Easily fixed by using std::max<long> or similar explicit type, as long as the value fits in the destination type, unsigned int.

Comment 1 Jakub Jelinek 2021-05-31 11:32:22 UTC
Gentle ping: this bug is blocking an important gcc update in rawhide/f34.

Comment 2 Kevin Kofler 2021-06-14 09:33:26 UTC
Ping again…

Is anybody looking at QtWebEngine at all anymore or do I need to take the package back for something to happen? And if the latter, are you going to give it to me out voluntarily or do I really have to start the nonresponsive maintainer process? I understand that you are busy, we all are, but there are also the 5.15.x bugfix and security releases in upstream git that need to be worked on urgently.

I would have responded earlier, but I have been offline for the last 2 weeks for health reasons.

Comment 3 Rex Dieter 2021-06-15 18:44:47 UTC
I'll try the quick-n-dirty workaround suggested in bug #1945595 first.

Longer-term plans are to actually update qtwebengine, but upstream has made that complicated unfortunately.

Comment 4 Kevin Kofler 2021-06-15 19:03:08 UTC
Created attachment 1791365 [details]
qtwebengine-release.sh

The attached script builds a 5.15.3 release tarball (or at least it did back when 5.15.3 was current, I have not tried running it since, though I wrote it in such a way that it SHOULD keep working permanently). It is already outdated though because current is 5.15.4 now.

Comment 5 Rex Dieter 2021-06-16 14:11:31 UTC
unfortunately, the script you provided me via email no longer works, appears Qt shutdown code.qt.io.  I'm trying the debian equivalant of that to see if I can generate a workable tarball: current work-in-progress:

CURDIR=$(pwd)
TEMPDIR=$(mktemp -d)
VERSION=5.15.3
SUBMODULE_COMMIT=d9d9e606cb34b1b4ac0f44de132b1eb10763f1f6
cd ${TEMPDIR}
wget https://github.com/qt/qtwebengine/archive/${VERSION}.tar.gz && \
tar xzf ${VERSION}.tar.gz && \
cd qtwebengine-${VERSION}/src/3rdparty && \
wget https://github.com/qt/qtwebengine-chromium/archive/${SUBMODULE_COMMIT}.tar.gz && \
tar xz --strip-components=1 -f ${SUBMODULE_COMMIT}.tar.gz && \
rm ${SUBMODULE_COMMIT}.tar.gz && \
cd ${TEMPDIR}/qtwebengine-${VERSION} && \
cd src/3rdparty/chromium/third_party/devtools-frontend/src/node_modules && \
ls -A | grep -Ev '^(@types|rollup|typescript)$$' | xargs rm -rf && \
cd ${TEMPDIR} && \
tar cJ --sort=name -f ${CURDIR}/qtwebengine-opensource-src-${VERSION}.tar.xz qtwebengine-${VERSION} && \
rm -rf ${TEMPDIR}

Comment 6 Rex Dieter 2021-06-16 19:16:24 UTC
Arg, turns out my @dayjob wifi network makes .qt.io unreachable (just for me).  Nevermind.

Comment 7 Rex Dieter 2021-06-21 21:31:16 UTC
First try at 5.15.5 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=70574124

Comment 8 Rex Dieter 2021-06-25 14:16:08 UTC
Fixed 2 other FTBFS issues with 5.15.2, now hit a 3rd:

In file included from gen/v8/v8_base_without_compiler_jumbo_29.cc:6:
./../../3rdparty/chromium/v8/src/objects/js-list-format.cc: In static member function 'static v8::internal::MaybeHandle<v8::internal::JSListFormat> v8::internal::JSListFormat::New(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>)':
./../../3rdparty/chromium/v8/src/objects/js-list-format.cc:145:69: error: 'static icu_69::ListFormatter* icu_69::ListFormatter::createInstance(const icu_69::Locale&, const char*, UErrorCode&)' is private within this context
  145 |   icu::ListFormatter* formatter = icu::ListFormatter::createInstance(
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  146 |       icu_locale, GetIcuStyleString(style_enum, type_enum), status);
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  
In file included from ./../../3rdparty/chromium/v8/src/objects/js-list-format.cc:25,
                 from gen/v8/v8_base_without_compiler_jumbo_29.cc:6:
/usr/include/unicode/listformatter.h:267:27: note: declared private here
  267 |     static ListFormatter* createInstance(const Locale& locale, const char* style, UErrorCode& errorCode);
      |                           ^~~~~~~~~~~~~~

Comment 9 Rex Dieter 2021-06-25 14:17:14 UTC
*** Bug 1945595 has been marked as a duplicate of this bug. ***

Comment 11 Rex Dieter 2021-06-29 17:52:02 UTC
Succeeded, will followup with f34 builds soon (once I have rpmfusion updated too)

Comment 12 Jonathan Wakely 2021-06-29 19:19:28 UTC
Great, thanks very much

Comment 13 David Faure 2021-12-15 21:41:08 UTC
Upstream fix for the std::max(16384, SIGSTKSZ) issue posted to https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3340721


Note You need to log in before you can comment on or make changes to this bug.