1961103 – [RFE] Leapp can fail due to 3rd party DNF plugins

This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1961103 - [RFE] Leapp can fail due to 3rd party DNF plugins

Summary: [RFE] Leapp can fail due to 3rd party DNF plugins

Keywords:
Status:	CLOSED MIGRATED
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	leapp-repository
Sub Component:
Version:	7.9
Hardware:	All
OS:	Linux
Priority:	low
Severity:	low
Target Milestone:	rc
Target Release:	---
Assignee:	Leapp Notifications Bot
QA Contact:	upgrades-and-conversions
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1818088
TreeView+	depends on / blocked

Reported:	2021-05-17 09:15 UTC by Christophe Besson
Modified:	2024-06-14 01:31 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Doc Type:	Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed:	2023-09-12 11:09:45 UTC
Target Upstream Version:
Embargoed:
Flags:	pm-rhel: mirror+

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Issue Tracker	OAMG-4946	0	None	None	None	2023-05-11 07:11:18 UTC
Red Hat Issue Tracker	RHEL-3281	0	None	Migrated	None	2023-09-12 11:07:39 UTC

Description Christophe Besson 2021-05-17 09:15:29 UTC

Description of problem:
Customer installed a 3rd party DNF plugin named 'langpacks', provided by the dnf-langpacks package from the EPEL repository. This plugin comes with a bug and it breaks DNF:

# dnf -v
Loaded plugins: builddep, changelog, config-manager, copr, debug, debuginfo-install, download, generate_completion_cache, langpacks, needs-restarting, playground, repoclosure, repodiff, repograph, repomanage, reposync
Traceback (most recent call last):
  File "/usr/bin/dnf", line 58, in <module>
    main.user_main(sys.argv[1:], exit_code=True)
  File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 179, in user_main
    errcode = main(args)
  File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 64, in main
    return _main(base, args, cli_class, option_parser_class)
  File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 95, in _main
    cli.configure(list(map(ucd, args)), option_parser())
  File "/usr/lib/python2.7/site-packages/dnf/cli/cli.py", line 915, in configure
    self.base.init_plugins(opts.disableplugin, opts.enableplugin, self)
  File "/usr/lib/python2.7/site-packages/dnf/base.py", line 307, in init_plugins
    self._plugins._run_init(self, cli)
  File "/usr/lib/python2.7/site-packages/dnf/plugin.py", line 147, in _run_init
    plugin = p_cls(base, cli)
  File "/usr/lib/python2.7/site-packages/dnf-plugins/langpacks.py", line 732, in __init__
    config = self.read_config(self.base.conf, "langpacks")
TypeError: read_config() takes exactly 2 arguments (3 given)

A check to see whether a 3rd party DNF plugin is in use could prevent such an error.

Version-Release number of selected component (if applicable):
leapp-repository-0.13.0-2.el7_9.noarch

How reproducible:
100%

Steps to Reproduce:
1. Enable EPEL repo for RHEL 7
2. yum install dnf-langpacks
3. leapp upgrade

Actual results:
[ERROR] Actor: target_userspace_creator 
Message: Unable to install RHEL 8 userspace packages. 
Summary:    Details: Command ['systemd-nspawn', '--register=no', '--quiet', '-D', '/var/lib/leapp/scratch/mounts/root_/system_overlay', '--bind=/etc/hosts:/etc/hosts', '--setenv=LEAPP_NO_RHSM=0', '--setenv=LEAPP_EXPERIMENTAL=0', '--setenv=LEAPP_COMMON_TOOLS=:/etc/leapp/repos.d/system_upgrade/el7toel8/tools', '--setenv=LEAPP_COMMON_FILES=:/etc/leapp/repos.d/system_upgrade/el7toel8/files', '--setenv=LEAPP_UNSUPPORTED=0', '--setenv=LEAPP_EXECUTION_ID=7b9560ed-f9c6-45aa-94f0-935289fc8ed8', '--setenv=LEAPP_HOSTNAME=XXX', 'dnf', 'install', '-y', '--nogpgcheck', '--setopt=module_platform_id=platform:el8', '--setopt=keepcache=1', '--releasever', u'8.2', '--installroot', '/el8target', '--disablerepo', '*', '--enablerepo', u'rhel-8-for-ppc64le-appstream-rpms', '--enablerepo', u'rhel-8-for-ppc64le-baseos-rpms', '--enablerepo', u'rhel-8-for-ppc64le-supplementary-rpms', 'dnf'] failed with exit code 1. 
    Stderr: Host and machine ids are equal (a43f5b58478c4f29ac84d2561e6b5000): refusing to link journals Traceback (most recent call last): 
              File "/usr/bin/dnf", line 58, in <module> 
                main.user_main(sys.argv[1:], exit_code=True) 
              File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 179, in user_main 
                errcode = main(args) 
              File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 64, in main 
                return _main(base, args, cli_class, option_parser_class) 
              File "/usr/lib/python2.7/site-packages/dnf/cli/main.py", line 95, in _main 
                cli.configure(list(map(ucd, args)), option_parser()) 
              File "/usr/lib/python2.7/site-packages/dnf/cli/cli.py", line 915, in configure 
                self.base.init_plugins(opts.disableplugin, opts.enableplugin, self) 
              File "/usr/lib/python2.7/site-packages/dnf/base.py", line 307, in init_plugins 
                self._plugins._run_init(self, cli) 
              File "/usr/lib/python2.7/site-packages/dnf/plugin.py", line 147, in _run_init 
                plugin = p_cls(base, cli) 
              File "/usr/lib/python2.7/site-packages/dnf-plugins/langpacks.py", line 732, in __init__ 
              config = self.read_config(self.base.conf, "langpacks") 
              TypeError: read_config() takes exactly 2 arguments (3 given) 

Expected results:
An inhibitor to prevent this kind of issues related to a 3rd party plugin

Comment 2 Petr Stodulka 2021-05-17 10:22:14 UTC

Thank you Chris for the report. I am thinking with the idea to disable all dnf plugins by default and enable just those we require. Just not sure whether some disabled plugins could be crucial for the dnf regarding customer's setup. WDYT about that, instead of inhibitor? Probably we should discuss it with DNF team as well.

Comment 3 Christophe Besson 2021-05-17 12:22:41 UTC

It sounds relevant, and better than creating an inhibitor.
I can't give an exhaustive list, though.

Comment 9 RHEL Program Management 2023-09-12 11:04:43 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 10 RHEL Program Management 2023-09-12 11:09:45 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.

Note You need to log in before you can comment on or make changes to this bug.